[edk2-devel] [PATCH 2] VirtualKeyboardFeaturePkg: Pre OS virtual keyboard touch response are very slow with I2C touch panel

[Dandan Bi]

Reviewed-by: Dandan Bi <dandan.bi at intel.com<mailto:dandan.bi at intel.com>>


Thanks,
Dandan
From: Balaji, Madhusudhan <madhusudhan.balaji at intel.com>
Sent: Wednesday, August 3, 2022 1:02 AM
To: Thangaraj, KalaiyarasanX <kalaiyarasanx.thangaraj at intel.com>; devel at edk2.groups.io
Cc: Bi, Dandan <dandan.bi at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Pethaiyan, Madhan <madhan.pethaiyan at intel.com>; Esakkithevar, Kathappan <kathappan.esakkithevar at intel.com>; Balaji, Madhusudhan <madhusudhan.balaji at intel.com>
Subject: RE: [PATCH 2] VirtualKeyboardFeaturePkg: Pre OS virtual keyboard touch response are very slow with I2C touch panel

---------

Reviewed-by:Balaji, Madhusudhan madhusudhan.balaji at intel.com<mailto:madhusudhan.balaji at intel.com>

--------------

From: Thangaraj, KalaiyarasanX <kalaiyarasanx.thangaraj at intel.com<mailto:kalaiyarasanx.thangaraj at intel.com>>
Sent: Tuesday, August 2, 2022 2:49 PM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>
Cc: Thangaraj, KalaiyarasanX <kalaiyarasanx.thangaraj at intel.com<mailto:kalaiyarasanx.thangaraj at intel.com>>; Bi, Dandan <dandan.bi at intel.com<mailto:dandan.bi at intel.com>>; Gao, Liming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>; Pethaiyan, Madhan <madhan.pethaiyan at intel.com<mailto:madhan.pethaiyan at intel.com>>; Esakkithevar, Kathappan <kathappan.esakkithevar at intel.com<mailto:kathappan.esakkithevar at intel.com>>; Balaji, Madhusudhan <madhusudhan.balaji at intel.com<mailto:madhusudhan.balaji at intel.com>>
Subject: [PATCH 2] VirtualKeyboardFeaturePkg: Pre OS virtual keyboard touch response are very slow with I2C touch panel

On one Touch, multiple Reads happend and  this reads varying based on Key Press time.
Resulting in Multiple key press update on screen. This condition avoids KeyPressed skips
resulting due to faster key press and update only on valid key press.


Cc: Dandan Bi dandan.bi at intel.com<mailto:dandan.bi at intel.com>
Cc: Liming Gao gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>
Cc: Madhan Pethaiyan madhan.pethaiyan at intel.com<mailto:madhan.pethaiyan at intel.com>
Cc: Kathappan Esakkithevar kathappan.esakkithevar at intel.com<mailto:kathappan.esakkithevar at intel.com>
Cc: Madhusudhan Balaji madhusudhan.balaji at intel.com<mailto:madhusudhan.balaji at intel.com>
Signed-off-by: KalaiyarasanX Thangaraj kalaiyarasanx.thangaraj at intel.com<mailto:kalaiyarasanx.thangaraj at intel.com>
---
Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c        | 12 ++++++++++++
Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h |  6 ++++++
2 files changed, 18 insertions(+)

diff --git a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c
index 2b1216746b..8c9d5b9a86 100644
--- a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c
+++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c
@@ -512,6 +512,18 @@ VkTimer (
   if (!VkContext->TouchActive) {
     VkContext->KeyPressed = FALSE;
   }
+
+  //
+  // On one Touch, multiple Reads happend and  this reads varying based on Key Press time.
+  // Resulting in Multiple key press update on screen. This condition avoids Key Press skips
+  // resulting due to faster key press and update only on valid key press.
+  //
+  if ((Point.CurrentX != VkContext->PreviousX) || (Point.CurrentY != VkContext->PreviousY)) {
+     VkContext->KeyPressed = FALSE;
+  }
+  VkContext->PreviousX = Point.CurrentX;
+  VkContext->PreviousY = Point.CurrentY;
+
   ConvertCoordinate (VkContext, Point, &TouchX, &TouchY);

   if (!VkContext->KeyPressed &&
diff --git a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h
index 14a50fa5af..7090730861 100644
--- a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h
+++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h
@@ -373,6 +373,12 @@ struct _VK_CONTEXT {
   BOOLEAN                           IsRedrawUpdateUI;
   VK_PAGE_TYPE                      PageNumber;
   LIST_ENTRY                        NotifyList;
+
+  ///
+  /// Previous X and Y axis Buffer
+  ///
+  UINTN                             PreviousX;
+  UINTN                             PreviousY;
};

 ///
--
2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92075): https://edk2.groups.io/g/devel/message/92075
Mute This Topic: https://groups.io/mt/92766964/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20220803/a878828e/attachment-0001.htm>