[edk2-devel] [PATCH 1/1] Ext4Pkg: Sanity check the inode size

[Pedro Falcato]

Check its alignment and value for possible bad values.

Cc: Marvin Häuser <mhaeuser at posteo.de>
Signed-off-by: Pedro Falcato <pedro.falcato at gmail.com>
---
 Features/Ext4Pkg/Ext4Dxe/Superblock.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4Dxe/Superblock.c
index c22155ba11b4..edee051c41e8 100644
--- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c
+++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c
@@ -189,6 +189,12 @@ Ext4OpenSuperblock (
     Partition->FeaturesIncompat = Sb->s_feature_incompat;
     Partition->FeaturesRoCompat = Sb->s_feature_ro_compat;
     Partition->InodeSize        = Sb->s_inode_size;
+
+    // Check for proper alignment of InodeSize and that InodeSize is indeed larger than
+    // the minimum size, 128 bytes.
+    if (((Partition->InodeSize % 4) != 0) || (Partition->InodeSize < EXT4_GOOD_OLD_INODE_SIZE)) {
+      return EFI_VOLUME_CORRUPTED;
+    }
   } else {
     // GOOD_OLD_REV
     Partition->FeaturesCompat = Partition->FeaturesIncompat = Partition->FeaturesRoCompat = 0;
-- 
2.37.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92180): https://edk2.groups.io/g/devel/message/92180
Mute This Topic: https://groups.io/mt/92863643/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-