[edk2-devel] [PATCH v4 14/28] SecurityPkg: Fix GetVariableKey API

[Wang, Jian J]

Reviewed-by: Jian J Wang <jian.j.wang at intel.com>

Regards,
Jian

> -----Original Message-----
> From: Vang, Judah <judah.vang at intel.com>
> Sent: Thursday, August 11, 2022 2:53 PM
> To: devel at edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang at intel.com>; Yao, Jiewen <jiewen.yao at intel.com>;
> Mistry, Nishant C <nishant.c.mistry at intel.com>
> Subject: [PATCH v4 14/28] SecurityPkg: Fix GetVariableKey API
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> 
> V4: Applied code review - function comments need to match
> function prototype.
> 
> V1: Fix GetVariableKey API to match changes in header files.
> 
> Cc: Jian J Wang <jian.j.wang at intel.com>
> Cc: Jiewen Yao <jiewen.yao at intel.com>
> Cc: Nishant C Mistry <nishant.c.mistry at intel.com>
> Signed-off-by: Jian J Wang <jian.j.wang at intel.com>
> Signed-off-by: Nishant C Mistry <nishant.c.mistry at intel.com>
> Signed-off-by: Judah Vang <judah.vang at intel.com>
> ---
>  SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
> b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
> index a08def767b5f..2cf4b3cbf9f6 100644
> --- a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
> +++ b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
> @@ -1,7 +1,7 @@
>  /** @file
>    Null version of VariableKeyLib for build purpose. Don't use it in real product.
> 
> -Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2020 - 2022, Intel Corporation. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>    Retrieves the key for integrity and/or confidentiality of variables.
> 
>    @param[out]     VariableKey         A pointer to pointer for the variable key
> buffer.
> -  @param[in,out]  VariableKeySize     The size in bytes of the variable key.
> +  @param[in]      VariableKeySize     The size in bytes of the variable key.
> 
>    @retval       EFI_SUCCESS             The variable key was returned.
>    @retval       EFI_DEVICE_ERROR        An error occurred while attempting to get
> the variable key.
> @@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  EFI_STATUS
>  EFIAPI
>  GetVariableKey (
> -  OUT VOID       **VariableKey,
> -  IN  OUT UINTN  *VariableKeySize
> +  OUT VOID   *VariableKey,
> +  IN  UINTN  VariableKeySize
>    )
>  {
>    ASSERT (FALSE);
> --
> 2.35.1.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92603): https://edk2.groups.io/g/devel/message/92603
Mute This Topic: https://groups.io/mt/92953540/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-