[edk2-devel] [PATCH 5/6] ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2

[Sami Mujawar]

Hi Nhi,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar

On 23/08/2022 11:59 am, Nhi Pham wrote:
> From: Minh Nguyen <minhn at amperecomputing.com>
>
> This patch removes redundant updates of "BoardManufacturerType02"
> and "SerialNumberType02".
>
> Signed-off-by: Nhi Pham <nhi at os.amperecomputing.com>
> ---
>   ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> index f61546955f12..3441e7798860 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> @@ -120,16 +120,6 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer) {
>       STRING_TOKEN (STR_MISC_BASE_BOARD_SERIAL_NUMBER),
>
>       SerialNumberType02
>
>       );
>
> -  OemUpdateSmbiosInfo (
>
> -    mSmbiosMiscHiiHandle,
>
> -    STRING_TOKEN (STR_MISC_BASE_BOARD_MANUFACTURER),
>
> -    BoardManufacturerType02
>
> -    );
>
> -  OemUpdateSmbiosInfo (
>
> -    mSmbiosMiscHiiHandle,
>
> -    STRING_TOKEN (STR_MISC_BASE_BOARD_SERIAL_NUMBER),
>
> -    SerialNumberType02
>
> -    );
>
>     OemUpdateSmbiosInfo (
>
>       mSmbiosMiscHiiHandle,
>
>       STRING_TOKEN (STR_MISC_BASE_BOARD_SKU_NUMBER),
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92711): https://edk2.groups.io/g/devel/message/92711
Mute This Topic: https://groups.io/mt/93201509/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-