[edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

[Nate DeSimone]

Hi Chasel,

I have some minor feedback on PATCH 1/4. Specifically, some improvements are needed in the comments. The code itself looks good! For that reason, there is no need to send a V3 patch series. Please fix the comments then you are free to push the change.

With those changes...

Reviewed-by: Nate DeSimone <nathaniel.l.desimone at intel.com>

> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu at intel.com>
> Sent: Tuesday, August 9, 2022 5:48 PM
> To: devel at edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Zeng, Star <star.zeng at intel.com>
> Subject: [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
> 
> Add FSP 2.4 MultiPhase interfaces and implementation.
> 
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Cc: Star Zeng <star.zeng at intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu at intel.com>
> 
> V2:
> . Add FspMultiPhasePlatformGetNumberOfPhases() and
> FspWrapperPlatformMultiPhaseHandler() to support platform porting.
> 
> . Add FSP reset support in FspWrapperVariableRequestHandler()
> 
> . Fix bug that wrong parameter given when calling
> FspWrapperVariableRequestHandler()
> 
> . Corrected code comments.
> 
> Chasel Chiu (4):
>   IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.
>   IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase interface.
>   IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions.
>   IntelFsp2WrapperPkg: Implement FSP 2.4 MultiPhase wrapper handlers.
> 
>  IntelFsp2Pkg/FspSecCore/SecFsp.c
> |   4 ++++
>  IntelFsp2Pkg/FspSecCore/SecFspApiChk.c
> |   9 +++++++++
>  IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c
> | 184
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++
>  IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c
> |  30 ++++++++++++++++++++++++++++++
>  IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> |  33 +++++++++++++++++++++++++--------
>  IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> |  27 +++++++++++++++++++++------
> 
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSampl
> e/FspWrapperPlatformMultiPhaseLibSample.c       |  49
> +++++++++++++++++++++++++++++++++++++++++++++++++
> 
> IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWra
> pperMultiPhaseProcessLib.c                      | 355
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++
>  IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> |  75
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++
>  IntelFsp2Pkg/FspSecCore/Fsp24SecCoreS.inf
> |  59
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +
>  IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> | 304
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++
>  IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryS.nasm
> | 101
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++++++++++
>  IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm
> |   3 +++
>  IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> | 303
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++
>  IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryS.nasm
> | 108
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  IntelFsp2Pkg/FspSecCore/X64/FspApiEntryCommon.nasm
> |   3 +++
>  IntelFsp2Pkg/Include/FspEas/FspApi.h
> |  62
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++--
>  IntelFsp2Pkg/Include/FspGlobalData.h
> |   5 ++++-
>  IntelFsp2Pkg/Include/Library/FspMultiPhaseLib.h
> |  54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h
> |  19 +++++++++++++++++++
>  IntelFsp2Pkg/IntelFsp2Pkg.dec                                                                                       |
> 12 ++++++++++--
>  IntelFsp2Pkg/IntelFsp2Pkg.dsc                                                                                       |
> 4 ++++
>  IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
> |  50 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  IntelFsp2Pkg/Tools/SplitFspBin.py                                                                                   |
> 48 +++++++++++++++++++++++++-----------------------
>  IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> |   1 +
>  IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> |   3 ++-
>  IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h
> |  62
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++
>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> |  10 +++++++++-
>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> |   6 +++++-
> 
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSampl
> e/BaseFspWrapperPlatformMultiPhaseLibSample.inf |  37
> +++++++++++++++++++++++++++++++++++++
> 
> IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrappe
> rMultiPhaseProcessLib.inf                       |  48
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  31 files changed, 2023 insertions(+), 45 deletions(-)  create mode 100644
> IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c
>  create mode 100644
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSampl
> e/FspWrapperPlatformMultiPhaseLibSample.c
>  create mode 100644
> IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWra
> pperMultiPhaseProcessLib.c
>  create mode 100644 IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
>  create mode 100644 IntelFsp2Pkg/FspSecCore/Fsp24SecCoreS.inf
>  create mode 100644 IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
>  create mode 100644 IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryS.nasm
>  create mode 100644 IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
>  create mode 100644 IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryS.nasm
>  create mode 100644 IntelFsp2Pkg/Include/Library/FspMultiPhaseLib.h
>  create mode 100644
> IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
>  create mode 100644
> IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h
>  create mode 100644
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSampl
> e/BaseFspWrapperPlatformMultiPhaseLibSample.inf
>  create mode 100644
> IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrappe
> rMultiPhaseProcessLib.inf
> 
> --
> 2.35.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92988): https://edk2.groups.io/g/devel/message/92988
Mute This Topic: https://groups.io/mt/92928031/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-