[edk2-devel] [PATCH v1 1/2] UefiCpuPkg/Test: Move EfiMpServiceProtocol UT in a separate function
duntan
dun.tan at intel.com
Mon Dec 5 03:47:06 UTC 2022
Reviewed-by: Dun Tan <dun.tan at intel.com>
-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Jason Lou
Sent: Thursday, November 24, 2022 8:12 PM
To: devel at edk2.groups.io
Cc: Lou, Yun <yun.lou at intel.com>; Ni, Ray <ray.ni at intel.com>; Dong, Eric <eric.dong at intel.com>; Laszlo Ersek <lersek at redhat.com>; Kumar, Rahul R <rahul.r.kumar at intel.com>
Subject: [edk2-devel] [PATCH v1 1/2] UefiCpuPkg/Test: Move EfiMpServiceProtocol UT in a separate function
From: Jason Lou <yun.lou at intel.com>
Move the implementation of EfiMpServiceProtocol unit tests in a separate function in preparation for developing the UEFI application and dynamic command for the same unit tests.
Signed-off-by: Jason Lou <yun.lou at intel.com>
Reviewed-by: Ray Ni <ray.ni at intel.com>
Cc: Eric Dong <eric.dong at intel.com>
Cc: Laszlo Ersek <lersek at redhat.com>
Cc: Rahul Kumar <rahul1.kumar at intel.com>
---
UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServiceProtocolUnitTest.c | 30 +++++++++++++++----- UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommom.h | 2 +-
2 files changed, 24 insertions(+), 8 deletions(-)
diff --git a/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServiceProtocolUnitTest.c b/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServiceProtocolUnitTest.c
index 57f8ba3c06..5fe6369960 100644
--- a/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServiceProtocolUnitTest.c
+++ b/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServiceProt
+++ ocolUnitTest.c
@@ -187,18 +187,16 @@ MpServicesUnitTestWhoAmI (
} /**- Standard DXE driver or UEFI application entry point for unit test execution from DXE or UEFI Shell.- Initialize the unit test framework, suite, and unit tests for the EfiMpServiceProtocol and run the unit test.+ Initialize the unit test framework, suite and unit tests for the EfiMpServiceProtocol and run the unit tests. - @param[in] ImageHandle The firmware allocated handle for the EFI image.- @param[in] SystemTable A pointer to the EFI System Table.+ @retval EFI_SUCCESS Initialize the unit test framework, suite, unit tests and run the unit tests successfully.+ @retval Others Initialize the unit test framework, suite, unit tests or run the unit tests unsuccessfully. **/ EFI_STATUS EFIAPI-DxeEntryPoint (- IN EFI_HANDLE ImageHandle,- IN EFI_SYSTEM_TABLE *SystemTable+EfiMpServiceProtocolUnitTest (+ VOID ) { EFI_STATUS Status;@@ -242,3 +240,21 @@ EXIT:
return Status; }++/**+ Standard DXE driver or UEFI application entry point for unit test execution from DXE or UEFI Shell.+ Initialize the unit test framework, suite, and unit tests for the EfiMpServiceProtocol and run the unit test.++ @param[in] ImageHandle The firmware allocated handle for the EFI image.+ @param[in] SystemTable A pointer to the EFI System Table.++**/+EFI_STATUS+EFIAPI+DxeEntryPoint (+ IN EFI_HANDLE ImageHandle,+ IN EFI_SYSTEM_TABLE *SystemTable+ )+{+ return EfiMpServiceProtocolUnitTest ();+}diff --git a/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommom.h b/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommom.h
index abbbd2faba..d2b1633b4d 100644
--- a/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUnitTestCommom.h
+++ b/UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EfiMpServicesUni
+++ tTestCommom.h
@@ -1,5 +1,5 @@
/** @file- Common header file for EfiMpServiceProtocolUnitTest DXE driver.+ Common header file for EdkiiPeiMpServices2Ppi and EfiMpServiceProtocol unit test. Copyright (c) 2022, Intel Corporation. All rights reserved.<BR> --
2.28.0.windows.1
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96613): https://edk2.groups.io/g/devel/message/96613
Mute This Topic: https://groups.io/mt/95236455/6168883
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [dun.tan at intel.com] -=-=-=-=-=-=
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96936): https://edk2.groups.io/g/devel/message/96936
Mute This Topic: https://groups.io/mt/95236455/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list