[edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file

[Nickle Wang via groups.io]

Reviewed-by: Nickle Wang <nicklew at nvidia.com>

Regards,
Nickle

From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Igor Kulchytskyy via groups.io
Sent: Tuesday, December 6, 2022 10:32 PM
To: Chang, Abner <Abner.Chang at amd.com>; Michael D Kinney <michael.d.kinney at intel.com>; devel at edk2.groups.io
Cc: Nickle Wang <nicklew at nvidia.com>
Subject: Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file

External email: Use caution opening links or attachments

Reviewed-by: Igor Kulchytskyy <igork at ami.com<mailto:abner.chang at amd.com>>

Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Chang, Abner <Abner.Chang at amd.com<mailto:Abner.Chang at amd.com>>
Sent: Tuesday, December 6, 2022 3:23:56 AM
To: Michael D Kinney <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>>
Cc: Nickle Wang <nicklew at nvidia.com<mailto:nicklew at nvidia.com>>; Igor Kulchytskyy <igork at ami.com<mailto:igork at ami.com>>
Subject: [EXTERNAL] RE: [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang at amd.com<mailto:abner.chang at amd.com>>

> -----Original Message-----
> From: Michael D Kinney <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
> Sent: Tuesday, December 6, 2022 8:45 AM
> To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> Cc: Chang, Abner <Abner.Chang at amd.com<mailto:Abner.Chang at amd.com>>; Nickle Wang
> <nicklew at nvidia.com<mailto:nicklew at nvidia.com>>; Igor Kulchytskyy <igork at ami.com<mailto:igork at ami.com>>
> Subject: [Patch 1/1] RedfishPkg: Remove overlapping private include path in
> DEC file
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Update ReadfishPkg.dec to remove PrivateInclude from the
> [Includes.Common.Private] section.  The PrivateInclude directory does not
> contain any include files, and the PrivateInclude/Crt include path remaining in
> the [Includes.Common.Private] section providing the include path required
> to access the CRT related include files by components within the RedfishPkg.
>
> Without this update, there are two forms of #include statements that can be
> used to include the CRT related include files.
> Include files should only be available using one form of #include statements.
>
> Cc: Abner Chang <abner.chang at amd.com<mailto:abner.chang at amd.com>>
> Cc: Nickle Wang <nicklew at nvidia.com<mailto:nicklew at nvidia.com>>
> Cc: Igor Kulchytskyy <igork at ami.com<mailto:igork at ami.com>>
> Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>
> ---
>  RedfishPkg/RedfishPkg.dec | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index
> 0aa26883e220..d2b189b13d8c 100644
> --- a/RedfishPkg/RedfishPkg.dec
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -17,7 +17,6 @@ [Includes]
>    Include
>
>  [Includes.Common.Private]
> -  PrivateInclude                # Private header files for C RTL.
>    PrivateInclude/Crt            # Private header files for C RTL.
>    Library/JsonLib               # Private header files for jansson
>                                  # configuration files.
> --
> 2.37.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97063): https://edk2.groups.io/g/devel/message/97063
Mute This Topic: https://groups.io/mt/95483555/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20221207/dbd346a7/attachment.htm>