[edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib

[Ni, Ray]

Yes. I am not sure if the preference for modules in other packages.
But for code in UefiCpuPkg, I don't prefer this way.

Thanks,
Ray

> -----Original Message-----
> From: Sunil V L <sunilvl at ventanamicro.com>
> Sent: Thursday, December 8, 2022 12:58 PM
> To: devel at edk2.groups.io; Ni, Ray <ray.ni at intel.com>
> Cc: Wang, Jian J <jian.j.wang at intel.com>; Gao, Liming
> <gaoliming at byosoft.com.cn>; Dong, Eric <eric.dong at intel.com>; Kumar,
> Rahul R <rahul.r.kumar at intel.com>; De, Debkumar
> <debkumar.de at intel.com>; West, Catharine <catharine.west at intel.com>;
> Daniel Schaefer <git at danielschaefer.me>; Abner Chang
> <Abner.Chang at amd.com>; Leif Lindholm <quic_llindhol at quicinc.com>;
> Andrew Fish <afish at apple.com>; Ard Biesheuvel <ardb at kernel.org>;
> Heinrich Schuchardt <heinrich.schuchardt at canonical.com>; Anup Patel
> <apatel at ventanamicro.com>
> Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V
> support in DxeCpuExceptionHandlerLib
> 
> On Thu, Dec 08, 2022 at 12:30:04AM +0000, Ni, Ray wrote:
> > Sunil,
> > Is there any source code sharing between Risc-V and IA32X64?
> > From the patch, I cannot see any.
> > If that's the case, I would prefer we don't mix the two separate
> implementations together into one component.
> > Can you please create a new CpuExceptionHandlerLib instance for Risc-V
> instead of including the Risc-V sources into the existing INF?
> >
> Thank you very much Ray. Sure. That approach is also fine with me.
> 
> BTW, https://edk2.groups.io/g/devel/message/95726 was the latest series.
> Sorry for the confusion. Let me update this series and send new version.
> I think your input is valid for other modules also like TimerLib.
> 
> Thanks
> Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97132): https://edk2.groups.io/g/devel/message/97132
Mute This Topic: https://groups.io/mt/93522716/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-