[edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions
Michael D Kinney
michael.d.kinney at intel.com
Tue Dec 20 20:51:19 UTC 2022
Judah,
The readme update was not complete.
I provided a pointer to the Table at the beginning of the readme
that need to be updated too.
Thanks,
Mike
> -----Original Message-----
> From: Vang, Judah <judah.vang at intel.com>
> Sent: Tuesday, December 20, 2022 10:43 AM
> To: Yao, Jiewen <jiewen.yao at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>; devel at edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang at intel.com>; Xiaoyu Lu <xiaoyux.lu at intel.com>; Jiang, Guomin <guomin.jiang at intel.com>;
> Mistry, Nishant C <nishant.c.mistry at intel.com>
> Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions
>
> The readme was updated, however, I did miss the .dsc.
> Will submit another patch to address the .dsc file
>
> Judah
>
> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao at intel.com>
> Sent: Monday, December 19, 2022 6:52 PM
> To: Kinney, Michael D <michael.d.kinney at intel.com>; devel at edk2.groups.io; Vang, Judah <judah.vang at intel.com>
> Cc: Wang, Jian J <jian.j.wang at intel.com>; Xiaoyu Lu <xiaoyux.lu at intel.com>; Jiang, Guomin <guomin.jiang at intel.com>;
> Mistry, Nishant C <nishant.c.mistry at intel.com>
> Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions
>
> Hi Mike
> You are right. I missed that part.
>
> Hi Judah
> Would you please file another patch to update DSC file, to make it align with readme?
>
> Thank you
> Yao, Jiewen
>
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney at intel.com>
> > Sent: Tuesday, December 20, 2022 9:55 AM
> > To: devel at edk2.groups.io; Yao, Jiewen <jiewen.yao at intel.com>; Vang,
> > Judah <judah.vang at intel.com>
> > Cc: Wang, Jian J <jian.j.wang at intel.com>; Xiaoyu Lu
> > <xiaoyux.lu at intel.com>; Jiang, Guomin <guomin.jiang at intel.com>;
> > Mistry, Nishant C <nishant.c.mistry at intel.com>; Kinney, Michael D
> > <michael.d.kinney at intel.com>
> > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable
> > crypto functions
> >
> > Hi Jiewen,
> >
> > I noticed that this patch is missing the update to the table in
> > ReadMe.md to show the new PEI and SMM crypto services enabled by
> > default in *CryptLib library instances.
> >
> > https://github.com/tianocore/edk2/tree/master/CryptoPkg#supported-
> > cryptographic-families-and-services
> >
> > It did update the recommended PCD settings at the end of the ReadMe,
> > but missed the update to CryptoPkg.dsc file to actually enable the PEI
> > and SMM services in the Crypto Drivers.
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Yao,
> > Jiewen
> > > Sent: Monday, December 19, 2022 5:40 PM
> > > To: Vang, Judah <judah.vang at intel.com>; devel at edk2.groups.io
> > > Cc: Wang, Jian J <jian.j.wang at intel.com>; Xiaoyu Lu
> > <xiaoyux.lu at intel.com>; Jiang, Guomin <guomin.jiang at intel.com>;
> > > Mistry, Nishant C <nishant.c.mistry at intel.com>
> > > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable
> > > crypto
> > functions
> > >
> > > Just merged - https://github.com/tianocore/edk2/pull/3796
> > >
> > >
> > > > -----Original Message-----
> > > > From: Vang, Judah <judah.vang at intel.com>
> > > > Sent: Tuesday, December 20, 2022 8:44 AM
> > > > To: devel at edk2.groups.io; Vang, Judah <judah.vang at intel.com>
> > > > Cc: Yao, Jiewen <jiewen.yao at intel.com>; Wang, Jian J
> > > > <jian.j.wang at intel.com>; Xiaoyu Lu <xiaoyux.lu at intel.com>; Jiang,
> > Guomin
> > > > <guomin.jiang at intel.com>; Mistry, Nishant C
> > <nishant.c.mistry at intel.com>
> > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable
> > crypto
> > > > functions
> > > >
> > > > Hi Jiewen,
> > > >
> > > > Has this patch been merged?
> > > > This is an important change for the UEFI Protected Variable feature.
> > > >
> > > > Judah
> > > >
> > > > -----Original Message-----
> > > > From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of
> > Judah
> > > > Vang
> > > > Sent: Monday, November 7, 2022 2:16 PM
> > > > To: devel at edk2.groups.io
> > > > Cc: Yao, Jiewen <jiewen.yao at intel.com>; Wang, Jian J
> > > > <jian.j.wang at intel.com>; Xiaoyu Lu <xiaoyux.lu at intel.com>; Jiang,
> > Guomin
> > > > <guomin.jiang at intel.com>; Mistry, Nishant C
> > <nishant.c.mistry at intel.com>
> > > > Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable
> > > > crypto functions
> > > >
> > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992
> > > >
> > > > V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase.
> > > > Update Readme.md
> > > >
> > > > Cc: Jiewen Yao <jiewen.yao at intel.com>
> > > > Cc: Jian J Wang <jian.j.wang at intel.com>
> > > > Cc: Xiaoyu Lu <xiaoyux.lu at intel.com>
> > > > Cc: Guomin Jiang <guomin.jiang at intel.com>
> > > > Cc: Nishant C Mistry <nishant.c.mistry at intel.com>
> > > > Signed-off-by: Jian J Wang <jian.j.wang at intel.com>
> > > > Signed-off-by: Nishant C Mistry <nishant.c.mistry at intel.com>
> > > > Signed-off-by: Judah Vang <judah.vang at intel.com>
> > > > ---
> > > > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +-
> > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +-
> > > > CryptoPkg/Readme.md | 27 +++++++++++---------
> > > > 3 files changed, 17 insertions(+), 14 deletions(-)
> > > >
> > > > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > > > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > > > index b1629647f9c6..ee5f3cd5d4b6 100644
> > > > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > > > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > > > @@ -43,7 +43,7 @@ [Sources]
> > > > Hash/CryptParallelHashNull.c
> > > > Hmac/CryptHmac.c
> > > > Kdf/CryptHkdf.c
> > > > - Cipher/CryptAesNull.c
> > > > + Cipher/CryptAes.c
> > > > Cipher/CryptAeadAesGcmNull.c
> > > > Pk/CryptRsaBasic.c
> > > > Pk/CryptRsaExtNull.c
> > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > index 0af7a3f96e8f..cc5a53ca92cd 100644
> > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > @@ -43,7 +43,7 @@ [Sources]
> > > > Hash/CryptCShake256.c
> > > > Hash/CryptParallelHash.c
> > > > Hmac/CryptHmac.c
> > > > - Kdf/CryptHkdfNull.c
> > > > + Kdf/CryptHkdf.c
> > > > Cipher/CryptAes.c
> > > > Cipher/CryptAeadAesGcmNull.c
> > > > Pk/CryptRsaBasic.c
> > > > diff --git a/CryptoPkg/Readme.md b/CryptoPkg/Readme.md index
> > > > 067465b8eb7d..cb072db72397 100644
> > > > --- a/CryptoPkg/Readme.md
> > > > +++ b/CryptoPkg/Readme.md
> > > > @@ -447,18 +447,20 @@ and CryptoSmm modules.
> > > > #### Common PEI PcdCryptoServiceFamilyEnable Settings
> > > >
> > > > ```
> > > > -
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.F
> > > > amily | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > -
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha384.F
> > > > amily | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > -
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > -
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > -
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > -
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha512.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > -
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sm3.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > -
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.
> > Pk
> > > > cs1Verify | TRUE
> > > > -
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.
> > N
> > > > ew | TRUE
> > > > -
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.
> > Fr
> > > > ee | TRUE
> > > > -
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.
> > Se
> > > > tKey | TRUE
> > > > -
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services
> > .P
> > > > kcs5HashPassword | TRUE
> > > > +
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.F
> > > > amily | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > +
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha384.F
> > > > amily | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > +
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > +
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > +
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > +
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha512.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > +
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sm3.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > +
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > +
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.
> > Pk
> > > > cs1Verify | TRUE
> > > > +
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.
> > N
> > > > ew | TRUE
> > > > +
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.
> > Fr
> > > > ee | TRUE
> > > > +
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.
> > Se
> > > > tKey | TRUE
> > > > +
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services
> > .P
> > > > kcs5HashPassword | TRUE
> > > > +
> > > > +
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Hkdf.Services
> > > > + .Sha256ExtractAndExpand | TRUE
> > > > ```
> > > >
> > > > #### Common DXE and SMM PcdCryptoServiceFamilyEnable Settings
> > @@ -
> > > > 466,6 +468,7 @@ and CryptoSmm modules.
> > > > ```
> > > >
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.F
> > > > amily | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > >
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha384.F
> > > > amily | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > > +
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Hkdf.Family
> > > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> > > >
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services
> > .P
> > > > kcs1v2Encrypt | TRUE
> > > >
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services
> > .P
> > > > kcs5HashPassword | TRUE
> > > >
> > > >
> > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services
> > .P
> > > > kcs7Verify | TRUE
> > > > --
> > > > 2.35.1.windows.2
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97636): https://edk2.groups.io/g/devel/message/97636
Mute This Topic: https://groups.io/mt/95777592/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list