[edk2-devel] [edk2-platforms][PATCH 1/1] AmpereAltraPkg: Remove MemoryAllocationLib in ArmPlatformLib

[Nhi Pham via groups.io]

Thanks Ard for reviewing them.

Sorry, I'm not aware of the SetTime() issue since I have not setup my 
mailbox for receiving the Linux kernel mails. Let me forward this issue 
to appropriate UEFI team and Linux kernel team to investigate.

Thanks,

-Nhi

On 12/23/2022 9:37 PM, Ard Biesheuvel wrote:
> On Wed, 21 Dec 2022 at 06:01, Nhi Pham <nhi at os.amperecomputing.com> wrote:
>> From: Tinh Nguyen <tinhnguyen at os.amperecomputing.com>
>>
>> PrePeiCore's Arm module just added a requirement to run all library
>> constructors that PrePeiCore uses. One of them is included in the
>> constructor of the ExtractGuidedSectionLib. This constructor will build
>> a HOB that is not supported "at this time" and causes an error.
>> We don't need to use this constructor because PrePeiCore doesn't
>> really need this library.
>>
>> This is a workaround to avoid PrePeiCore module calling
>> ExtractGuidedSectionLib's constructor.
>>
>> Signed-off-by: Nhi Pham <nhi at os.amperecomputing.com>
>> ---
>>   .../AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.inf     | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.inf b/Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
>> index a4d29379198d..a61da278c705 100644
>> --- a/Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
>> +++ b/Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
>> @@ -25,7 +25,6 @@ [LibraryClasses]
>>     ArmSmcLib
>>     HobLib
>>     IoLib
>> -  MemoryAllocationLib
>>     PL011UartLib
>>     PcdLib
>>     SerialPortLib
> Hi,
>
> Thanks for these patches - I will merge them shortly.
>
> As an aside, do you have any news on the issue I reported recently
> regarding SetTime() on Altra which crashes the system if
> SetVirtualAddressMap() was not called?
>
> https://lore.kernel.org/all/Y2o1hdZK9GGDVJsS@monolith.localdoman/


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97747): https://edk2.groups.io/g/devel/message/97747
Mute This Topic: https://groups.io/mt/95801452/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-