[edk2-devel] [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout

PierreGondois pierre.gondois at arm.com
Wed Feb 2 09:42:44 UTC 2022


Hi,
The value also gets updated from 3 to 5, is it possible to note it in the
commit message or to let it to 3 ?
Otherwise the patch looks good to me,

Reviewed-by: Pierre Gondois <pierre.gondois at arm.com>


On 2/1/22 7:03 PM, Ard Biesheuvel wrote:
> Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up
> to the Timeout EFI variable automatically, which is how the boot manager
> stores the timeout preference.
> 
> Signed-off-by: Ard Biesheuvel <ardb at kernel.org>
> ---
>   ArmVirtPkg/ArmVirtKvmTool.dsc | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc
> index a1bf4b9be87b..3bd3ebd6e0b3 100644
> --- a/ArmVirtPkg/ArmVirtKvmTool.dsc
> +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc
> @@ -170,9 +170,10 @@ [PcdsPatchableInModule.common]
>   
>     gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x0
>   
> +[PcdsDynamicHii]
> +  gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalVariableGuid|0x0|5
> +
>   [PcdsDynamicDefault.common]
> -  gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
> -
>     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0
>     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x0
>     gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|0x0
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86331): https://edk2.groups.io/g/devel/message/86331
Mute This Topic: https://groups.io/mt/88839170/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list