[edk2-devel] [PATCH v3 1/3] DynamicTablesPkg: Add Memory32Fixed function

[Rebecca Cran]

On 2/2/22 07:52, Sami Mujawar wrote:
>> +AmlCodeGenRdMemory32Fixed (
>> +  BOOLEAN                 IsReadWrite,
>> +  UINT32                  Address,
>> +  UINT32                  RangeLength,
>> +  AML_OBJECT_NODE_HANDLE  NameOpNode,
>> +  AML_DATA_NODE_HANDLE    *NewMemNode
>> +  )
>> +{
>> +  EFI_STATUS                                     Status;
>> +  AML_DATA_NODE                                  *MemNode;
>> +  EFI_ACPI_32_BIT_FIXED_MEMORY_RANGE_DESCRIPTOR  RangeDesc;
>> +
>> +  RangeDesc.Header.Header.Byte = ACPI_32_BIT_FIXED_MEMORY_RANGE_DESCRIPTOR;
>> +  RangeDesc.Header.Length      = 0x09;
> [SAMI] Would it be ok if I change the above line to
> RangeDesc.Header.Length     = sizeof 
> (EFI_ACPI_32_BIT_FIXED_MEMORY_RANGE_DESCRIPTOR) -
>                                     sizeof (ACPI_LARGE_RESOURCE_HEADER);
> before merging?
> [/SAMI]

Yes, that would be good.


Thanks.

Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86339): https://edk2.groups.io/g/devel/message/86339
Mute This Topic: https://groups.io/mt/88400644/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20220202/23fee771/attachment.htm>