[edk2-devel] [edk2-platform PATCH v1] Silicon/Marvell/Armada7k8k: Fix wrong SMBIOS version issue

[Ard Biesheuvel]

On Wed, 12 Jan 2022 at 00:00, Marcin Wojtas <mw at semihalf.com> wrote:
>
> wt., 11 sty 2022 o 22:46 Sunny Wang <Sunny.Wang at arm.com> napisał(a):
> >
> > The SMBIOS data is based on v3.3.0, but its version is set to v3.2.0.
> > Since PcdSmbiosVersion in MdeModulePkg.dec is v3.3.0, so just remove
> > the platform overridden value in .dsc file to fix this issue.
> >
> > This also fixed the FWTS failure below:
> >  dmicheck: Type 17 expects length of 0x54, has incorrect length of 0x5c
> >
> > Cc: Leif Lindholm <leif at nuviainc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> > Cc: Marcin Wojtas <mw at semihalf.com>
> > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud at arm.com>
> >
> > Signed-off-by: Sunny Wang <sunny.wang at arm.com>
> > ---
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > index 3b76acd99c..5e15378207 100644
> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > @@ -1,5 +1,5 @@
> >  #
> > -#Copyright (c) 2011-2012, ARM Limited. All rights reserved.
> > +#Copyright (c) 2011-2022, ARM Limited. All rights reserved.
> >  #Copyright (C) 2016 Marvell International Ltd.
> >  #
> >  #SPDX-License-Identifier: BSD-2-Clause-Patent
> > @@ -387,7 +387,6 @@
> >    # SMBIOS/DMI
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x2
> > -  gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0302
> >    gMarvellTokenSpaceGuid.PcdFirmwareVersion|"EDK2 SH 1.1"
> >
>
>
> Reviewed-by: Marcin Wojtas <mw at semihalf.com>
>

Pushed as d5ead8b73d62..60bb320b9e47

But in the future, please omit the copyright banner updates if you are
not making changes that establish copyright on the code (and I don't
see how that could be the case when you are deleting a single line)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85613): https://edk2.groups.io/g/devel/message/85613
Mute This Topic: https://groups.io/mt/88360051/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-