[edk2-devel] [PATCH V4 22/31] OvmfPkg: Update PlatformPei to support TDX

[Min Xu]

Thanks for reminder. It is in-consistent implementation between config-A and config-B. I will fix it in the next version.

From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Vishal Annapurve via groups.io
Sent: Friday, January 14, 2022 10:37 AM
To: Xu, Min M <min.m.xu at intel.com>; devel at edk2.groups.io
Subject: Re: [edk2-devel] [PATCH V4 22/31] OvmfPkg: Update PlatformPei to support TDX

Thanks Min for the reference of the firmware design guide.

If VMM is expected to set it then issue I mentioned with CoreInitializeMemoryServices can be ignored.

Though its mentioned in the design guide, I was confused by the current implementation of TDX Qemu as per:
https://github.com/intel/qemu-tdx/blob/tdx/hw/i386/tdvf-hob.c#L169
https://github.com/intel/qemu-tdx/blob/852a069e739a6ffae4f9dec17607a74690b0e4af/hw/i386/tdvf-hob.h#L15

and config B patches:
https://github.com/mxu9/edk2/commit/c5d5786290b2455c5a0a7e3515cf04ec2218d8a4#diff-7cb0d3ac758c9b92166d03049917116ca4a5cb012db99deb491f63c5c5562e0aR124

It's possible that I have incomplete view of Qemu implementation or Config B patches.

Regards,
Vishal



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85694): https://edk2.groups.io/g/devel/message/85694
Mute This Topic: https://groups.io/mt/87696595/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20220114/ea9c641c/attachment.htm>