[edk2-devel] [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase

[Gerd Hoffmann]

On Fri, Jan 28, 2022 at 08:02:23AM +0000, Xu, Min M wrote:
> On January 27, 2022 9:24 PM, Gerd Hoffmann wrote:
> > On Tue, Jan 25, 2022 at 02:33:10PM +0800, Min Xu wrote:
> > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> > >
> > > Add PcdTdxWorkAreaBase to indicate the area of memory where the TDX
> > > work area block lives.
> > 
> > Why have both PcdSevEsWorkAreaBase and PcdTdxWorkAreaBase when we
> > have a shared work area?
> PcdTdxWorkAreaBase mimics PcdSevEsWorkAreaBase. Yes, TdxWorkAreaBase is same as SevEsWorkAreaBase. But the name of TdxWorkAreaBase is more meaningful in the Tdx related code.

Yes, using PcdSevEsWorkAreaBase in TDX code would look somewhat odd, but
we can rename the PCD to have 'CC' in the name like we already did for
other bits shared between sev and tdx.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86149): https://edk2.groups.io/g/devel/message/86149
Mute This Topic: https://groups.io/mt/88666800/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-