[edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning

[Rebecca Cran]

I'm still seeing this error when building using XCode 13.2.1, so I guess 
this patch hasn't been committed yet.


--

Rebecca Cran


On 12/13/21 12:38 PM, Brijesh Singh via groups.io wrote:
> The XCODE5 reported the below warning
>
> OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uninitialized use occurs here
>             Compacted
>             ^^^^^^^^^
>
> Initialize the 'Compacted' variable to fix the warning.
>
> Fixes: d2b998fbdca4 (OvmfPkg/VmgExitLib: use SEV-SNP-validated CPUID values)
> Cc: James Bottomley <jejb at linux.ibm.com>
> Cc: Min Xu <min.m.xu at intel.com>
> Cc: Jiewen Yao <jiewen.yao at intel.com>
> Cc: Tom Lendacky <thomas.lendacky at amd.com>
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> Cc: Erdem Aktas <erdemaktas at google.com>
> Cc: Gerd Hoffmann <kraxel at redhat.com>
> Cc: Rebecca Cran <rebecca at bsdio.com>
> Cc: Michael Roth <Michael.Roth at amd.com>
> Signed-off-by: Brijesh Singh <brijesh.singh at amd.com>
> ---
>   OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> index a40a31f7c275..ff367411cc59 100644
> --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> @@ -1872,6 +1872,7 @@ GetCpuidFw (
>       UINT32                 XSaveSize;
>   
>       XssMsr.Uint64 = 0;
> +    Compacted = FALSE;
>       if (EcxIn == 1) {
>         /*
>          * The PPR and APM aren't clear on what size should be encoded in


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86229): https://edk2.groups.io/g/devel/message/86229
Mute This Topic: https://groups.io/mt/87705849/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-