[edk2-devel] [PATCH v1] Silicon/Intel/FitGen: Fix Type 2 entry version value from BiosInfo would always 0x0

[Chaganty, Rangasai V]

Reviewed-by: Sai Chaganty <rangasai.v.chaganty at intel.com>

-----Original Message-----
From: Lin, Jason1 <jason1.lin at intel.com> 
Sent: Tuesday, July 12, 2022 10:56 PM
To: devel at edk2.groups.io
Cc: Lin, Jason1 <jason1.lin at intel.com>; Feng, Bob C <bob.c.feng at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Chen, Christine <yuwei.chen at intel.com>; Oram, Isaac W <isaac.w.oram at intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty at intel.com>; Chiang, Dakota <dakota.chiang at intel.com>
Subject: [PATCH v1] Silicon/Intel/FitGen: Fix Type 2 entry version value from BiosInfo would always 0x0

From: Jason1 Lin <jason1.lin at intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3988

With the change #3958 using the incorrect variable to store the S-ACM entry version.
That would cause the value always 0x0.

gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].Version
variable should be corrected to
gFitTableContext.StartupAcmVersion[gFitTableContext.StartupAcmNumber].

Signed-off-by: Jason1 Lin <jason1.lin at intel.com>
Cc: Bob Feng <bob.c.feng at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen at intel.com>
Cc: Isaac W Oram <isaac.w.oram at intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty at intel.com>
Cc: Dakota Chiang <dakota.chiang at intel.com>
---
 Silicon/Intel/Tools/FitGen/FitGen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c b/Silicon/Intel/Tools/FitGen/FitGen.c
index 577ce48b10..21dfcf1ebb 100644
--- a/Silicon/Intel/Tools/FitGen/FitGen.c
+++ b/Silicon/Intel/Tools/FitGen/FitGen.c
@@ -1182,7 +1182,7 @@ Returns:
           gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].Type    = FIT_TABLE_TYPE_STARTUP_ACM;           gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].Address = (UINT32)BiosInfoStruct[BiosInfoIndex].Address;           gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].Size    = (UINT32)BiosInfoStruct[BiosInfoIndex].Size;-          gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].Version = BiosInfoStruct[BiosInfoIndex].Version;+          gFitTableContext.StartupAcmVersion[gFitTableContext.StartupAcmNumber]  = BiosInfoStruct[BiosInfoIndex].Version;           gFitTableContext.StartupAcmNumber ++;           gFitTableContext.FitEntryNumber ++;           break;-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91298): https://edk2.groups.io/g/devel/message/91298
Mute This Topic: https://groups.io/mt/92352273/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-