[edk2-devel] [PATCH v1 1/1] DynamicTables: Fix DT PCI interrupt flags parsing
Sami Mujawar
sami.mujawar at arm.com
Mon Jul 18 12:27:28 UTC 2022
Hi Pierre,
Please find my response inline marked [SAMI]
Regards,
Sami Mujawar
On Wed, Apr 27, 2022 at 07:49 AM, PierreGondois wrote:
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci=
>
> eGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtP=
>
> cieGenerator.c
> index a34018151f2d..d5b1c153e98f 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera=
>
> tor.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera=
>
> tor.c
> @@ -449,7 +449,7 @@ GeneratePrt (
> if ((Index > 0) &&
> (IrqMapInfo->IntcInterrupt.Interrupt >=3D 32) &&
> (IrqMapInfo->IntcInterrupt.Interrupt < 1020) &&
> - ((IrqMapInfo->IntcInterrupt.Flags & 0x3) !=3D BIT0))
> + ((IrqMapInfo->IntcInterrupt.Flags & 0x3) !=3D 0))
[SAMI] The BSA 1.0 says " Each legacy interrupt SPI must be programmed as level-sensitive ".
Considering this, I think the above check should be ((IrqMapInfo->IntcInterrupt.Flags & 0xB) != 0).
If you agree, please let me know I will make that change locally before pushing.
[/SAMI]
>
> {
> Status =3D EFI_INVALID_PARAMETER;
> ASSERT_EFI_ERROR (Status);
> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h b/D=
>
> ynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91445): https://edk2.groups.io/g/devel/message/91445
Mute This Topic: https://groups.io/mt/90732275/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20220718/113cd26f/attachment-0001.htm>
More information about the edk2-devel-archive
mailing list