[edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout

[Nate DeSimone]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone at intel.com>

-----Original Message-----
From: Oram, Isaac W <isaac.w.oram at intel.com> 
Sent: Tuesday, June 7, 2022 4:49 PM
To: devel at edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Chiu, Chasel <chasel.chiu at intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout

V2:
Use UINT8 instead of BOOLEAN for DmiStopAndScreamEnable and Rsvdbits2

V1: 
Disambiguate the PCH_DMI_CONFIG and PCH_TRACE_HUB_CONFIG structure definitions such that compilers generate same binary layouts.

Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Chasel Chiu <chasel.chiu at intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram at intel.com>
---
 .../Pch/SouthClusterLbg/Include/PchPolicyCommon.h            | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h
index 0e10d0b8f0..11057a3ace 100644
--- a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h
+++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPol
+++ icyCommon.h
@@ -1351,7 +1351,9 @@ typedef struct {
   **/
   UINT32     DmiAspm           :  1;
   UINT32     PwrOptEnable      :  1;    ///< <b>0: Disable</b>; 1: Enable DMI Power Optimizer on PCH side.
-  BOOLEAN    DmiStopAndScreamEnable : 1;
+  UINT32     Rsvdbits1         : 30;
+  UINT8      DmiStopAndScreamEnable : 1;
+  UINT8      Rsvdbits2              : 7;
   UINT32     DmiLinkDownHangBypass  : 1;
   UINT32     Rsvdbits               : 29;
   UINT32     Rsvd0[6];                  ///< Reserved bytes
@@ -1447,6 +1449,7 @@ typedef struct {
   TRACE_HUB_CONFIG            TraceHub;
   UINT32                      AetEnableMode      :  2;
   UINT32                      PchTraceHubHide    :  1;
+  UINT32                      Rsvdbits           : 29;
 } PCH_TRACE_HUB_CONFIG;
 
 
--
2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90342): https://edk2.groups.io/g/devel/message/90342
Mute This Topic: https://groups.io/mt/91613603/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-