回复: [edk2-devel] [PATCH 1/1] MdePkg: Remove "assert" from SmmCpuRendevousLibNull.c

[gaoliming]

Zhihao:
  This change has been merged at b09ada6edc7f3f28d3b4f2ef09852ebd39f17920 in
Edk2. Please check it. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Li, Zhihao
> 发送时间: 2022年6月20日 17:36
> 收件人: devel at edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney at intel.com>; Liming Gao
> <gaoliming at byosoft.com.cn>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Remove "assert" from
> SmmCpuRendevousLibNull.c
> 
> From: Zhihao Li <zhihao.li at intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3931
> 
> Some drivers will break down when they use
> SmmWaitForAllProcessor() which from SmmCpuRendezvousLibNull.c.
> Removing the code "ASSERT(False)" will make consumer
> work normally if they keep default setting for sync mode.
> 
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Liming Gao <gaoliming at byosoft.com.cn>
> 
> Signed-off-by: Zhihao Li <zhihao.li at intel.com>
> Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>
> ---
>  MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git
> a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> index 474195bbb374..769f4c673802 100644
> ---
> a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> +++
> b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> @@ -24,6 +24,5 @@ SmmWaitForAllProcessor (
>    IN BOOLEAN  BlockingMode
> 
>    )
> 
>  {
> 
> -  ASSERT (FALSE);
> 
>    return EFI_SUCCESS;
> 
>  }
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#90616): https://edk2.groups.io/g/devel/message/90616
> Mute This Topic: https://groups.io/mt/91873301/4905953
> Group Owner: devel+owner at edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming at byosoft.com.cn]
> -=-=-=-=-=-=
> 
> 






-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90631): https://edk2.groups.io/g/devel/message/90631
Mute This Topic: https://groups.io/mt/91879626/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-