[edk2-devel] [PATCH 3/3] OvmfPkg: Initialize NvVarStore with Configuration FV in Td guest

[Gerd Hoffmann]

> > Copying over the content in PlatformInitLib makes sense too, probably best
> > as separate function.

> Yes, PlatformReserveEmuVariableNvStore() will be a separated function
> and it returns the pointer of the allocated storage. Then this pointer
> can be set to either the PCD (PlatformPei) or in PlatformInfoHob
> (PeilessStartupLib).

I mean copying over should be a separate function too, so it is up to
the caller not the library itself to decide whenever the copying should
happen or not.

> > > > Also why limit this to tdx?
> > > Because I am not sure if other platforms need such operation. So in
> > > current stage it is limit to tdx.
> > 
> > I think the code should copy over the varstore in case the
> > SECURE_BOOT_ENABLE option is set.  That is the actual use case and it
> > makes sense without TDX too.
> Then we need add a build-flag in *.dsc. Do you think OvmfPkgX64.dsc and IntelTdxX64.dsc are enough?

The flag is already there ;)

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90673): https://edk2.groups.io/g/devel/message/90673
Mute This Topic: https://groups.io/mt/91835110/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-