[edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low Power Idle states for RD platforms

PierreGondois pierre.gondois at arm.com
Thu Jun 23 08:45:51 UTC 2022



On 6/22/22 07:39, Pranav Madhu wrote:
> Hi Pierre,
> 
> Thanks for reviewing this patch series. Please find my reply inline.
> 
> Regards,
> Pranav
> 
>> -----Original Message-----
>> From: Pierre Gondois <pierre.gondois at arm.com>
>> Sent: Tuesday, June 21, 2022 2:15 PM
>> To: devel at edk2.groups.io; Pranav Madhu <Pranav.Madhu at arm.com>;
>> Thomas Abraham <thomas.abraham at arm.com>
>> Cc: Sami Mujawar <Sami.Mujawar at arm.com>; Ard Biesheuvel
>> <ardb+tianocore at kernel.org>; nd <nd at arm.com>
>> Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low
>> Power Idle states for RD platforms
>>
>> Hello Pranav,
>> Would it be possible to extend this change to the Juno aswell as the platform
>> has a Null Residency Counter and doesn't support OS Initiated LPI ?
> 
> It can be changed for Juno as well, but I do not have access to any Juno boards and this patch series is focusing on RD platforms. The Juno board update can be posted as a separate patch.
> 

Ok sure.

>>
>> Another remark is that for RdV1MC, RdN2, RdV1 and RdN2Cfg1 platforms,
>> CPUs don't need to be encapsulated anymore in cluster objects
>> Cf:
>> Device (CL00) {   // Cluster 0
>>     Name (_HID, "ACPI0010")
>>     Name (_UID, 0)
>>     ...
>> }
>> since Clusters don't have any additional information. But keeping them is
>> correct aswell.
> 
> These platforms have a minimal cluster logic but does not support low power states. But the cluster encapsulation represents the platform topology accurately. So it would be better to keep the cluster encapsulation.

Ok yes, this was just so other people are aware of this.

Reviewed-by: Pierre Gondois <pierre.gondois at arm.com>

Regards,
Pierre

>>> ----------
>>> Groups.io Links:
>>>
>>> You receive all messages sent to this group.
>>>
>>> View/Reply Online (#90633)
>>> <https://edk2.groups.io/g/devel/message/90633> | | Mute This Topic
>>> <https://groups.io/mt/91652410/1821310> | New Topic
>>> <https://edk2.groups.io/g/devel/post>
>>> Your Subscription <https://edk2.groups.io/g/devel/editsub/1821310> |
>>> Contact Group Owner <mailto:devel+owner at edk2.groups.io> |
>> Unsubscribe
>>> <https://edk2.groups.io/g/devel/unsub> [pierre.gondois at arm.com]
>>>
>>> _._,_._,_


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90714): https://edk2.groups.io/g/devel/message/90714
Mute This Topic: https://groups.io/mt/91652410/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list