[edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message

Yuwei Chen yuwei.chen at intel.com
Fri Jun 24 01:24:55 UTC 2022


Reviewed-by: Yuwei Chen<yuwei.chen at intel.com>

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Rebecca
> Cran
> Sent: Monday, June 20, 2022 6:07 AM
> To: devel at edk2.groups.io; Feng, Bob C <bob.c.feng at intel.com>; Gao, Liming
> <gaoliming at byosoft.com.cn>; Chen, Christine <yuwei.chen at intel.com>
> Cc: Rebecca Cran <quic_rcran at quicinc.com>
> Subject: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error
> message
> 
> Signed-off-by: Rebecca Cran <quic_rcran at quicinc.com>
> ---
>  BaseTools/Source/Python/Ecc/c.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/Ecc/c.py
> b/BaseTools/Source/Python/Ecc/c.py
> index 4a82e5e76003..61ad084fcc5b 100644
> --- a/BaseTools/Source/Python/Ecc/c.py
> +++ b/BaseTools/Source/Python/Ecc/c.py
> @@ -2612,8 +2612,8 @@ def
> CheckFunctionHeaderConsistentWithDoxygenComment(FuncModifier,
> FuncHeader, Fu
> 
> 
>              if Tag.find(ParamName) == -1 and ParamName != 'VOID' and
> ParamName != 'void':
> -                ErrorMsgList.append('Line %d : in Comment, <%s> does NOT
> consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] +
> ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
> -                PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in
> Comment, <%s> does NOT consistent with parameter name %s ' %
> ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''),
> ParamName), TableName, CommentId)
> +                ErrorMsgList.append('Line %d : in Comment, <%s> is NOT
> consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] +
> ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
> +                PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in
> Comment, <%s> is NOT consistent with parameter name %s ' %
> ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''),
> ParamName), TableName, CommentId)
>              Index += 1
> 
>          if Index < ParamNumber:
> --
> 2.35.3
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90737): https://edk2.groups.io/g/devel/message/90737
Mute This Topic: https://groups.io/mt/91866114/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list