[edk2-devel] [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Guo, Gua
gua.guo at intel.com
Mon Jun 27 07:27:28 UTC 2022
@Ni, Ray<mailto:ray.ni at intel.com>
Below url is pull request link. May I get your help to add push label ? Have any concern, please also share for me.
URL: https://github.com/tianocore/edk2/pull/3015
Thanks,
Gua
-----Original Message-----
From: Ni, Ray <ray.ni at intel.com>
Sent: Monday, June 27, 2022 2:53 PM
To: Guo, Gua <gua.guo at intel.com>; devel at edk2.groups.io
Cc: Dong, Guo <guo.dong at intel.com>; Lu, James <james.lu at intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Reviewed-by: Ray Ni <ray.ni at intel.com<mailto:ray.ni at intel.com>>
> -----Original Message-----
> From: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>
> Sent: Monday, June 27, 2022 1:03 PM
> To: Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> Cc: Dong, Guo <guo.dong at intel.com<mailto:guo.dong at intel.com>>; Lu, James <james.lu at intel.com<mailto:james.lu at intel.com>>
> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL
> spec
>
> Yes, #2 is chosen in by the python interpreter.
>
> -----Original Message-----
> From: Guo, Gua
> Sent: Monday, June 27, 2022 12:07 PM
> To: Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> Cc: Dong, Guo <guo.dong at intel.com<mailto:guo.dong at intel.com>>; Lu, James <james.lu at intel.com<mailto:james.lu at intel.com>>
> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL
> spec
>
> The python logic will like for below
>
> > upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
> =========>
> > if BuildTarget == "DEBUG":
> > upld_info_hdr.Attribute |= 1
> > else:
> > upld_info_hdr.Attribute |= 0
>
> Thanks,
> Gua
>
> -----Original Message-----
> From: Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>
> Sent: Monday, June 27, 2022 11:44 AM
> To: Guo, Gua <gua.guo at intel.com<mailto:gua.guo at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> Cc: Dong, Guo <guo.dong at intel.com<mailto:guo.dong at intel.com>>; Lu, James <james.lu at intel.com<mailto:james.lu at intel.com>>
> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL
> spec
>
> > + upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
>
>
> I am not python expert. Above statement might be interpreted as:
> 1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0 2.
> upld_info_hdr.Attribute |= (1 if BuildTarget == "DEBUG" else 0)
>
> Are we sure that the #2 is chosen in by the python interpreter?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90803): https://edk2.groups.io/g/devel/message/90803
Mute This Topic: https://groups.io/mt/92013929/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20220627/7876cb1e/attachment-0001.htm>
More information about the edk2-devel-archive
mailing list