[edk2-devel] [PATCH 1/4] NetworkPkg/HttpDxe: Decofigure Tcp4 before reconfiguring

[Gerd Hoffmann]

On Fri, Mar 04, 2022 at 02:34:28PM +0100, Oliver Steffen wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
> 
> Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or
> HTTP_STATE_TCP_CLOSED and de-configure the Tcp4 instance before
> configuring it again.
> 
> Signed-off-by: Oliver Steffen <osteffen at redhat.com>
> ---
>  NetworkPkg/HttpDxe/HttpProto.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c
> index 9457dd2623..cd54c57404 100644
> --- a/NetworkPkg/HttpDxe/HttpProto.c
> +++ b/NetworkPkg/HttpDxe/HttpProto.c
> @@ -1086,6 +1086,18 @@ HttpConfigureTcp4 (
>    Tcp4Option->EnableNagle       = TRUE;
> 
>    Tcp4CfgData->ControlOption    = Tcp4Option;
> 
>  
> 
> +  if ((HttpInstance->State == HTTP_STATE_TCP_CONNECTED) ||
> 
> +      (HttpInstance->State == HTTP_STATE_TCP_CLOSED))

Line breaks are mangled, probably due to edk2 using dos/windows
style linebreaks.

Running BaseTools/Scripts/SetupGit.py once should update the git
configuration according.

Otherwise the patch looks good to me.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87311): https://edk2.groups.io/g/devel/message/87311
Mute This Topic: https://groups.io/mt/89555128/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-