[edk2-devel] [PATCH EDK2 v1 1/1] RedfishPkg: fix memory leak issue
wenyi,xie via groups.io
xiewenyi2=huawei.com at groups.io
Fri Mar 11 08:02:19 UTC 2022
Hi Abner,
Thank you for your reviewing, here is the link to the PR.
https://github.com/tianocore/edk2/pull/2612
Regards
Wenyi
On 2022/3/11 15:03, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hi Wenyi,
> Please add my RB in the commit message and create the PR against edk2, let me know the link to PR as well.
>
> Thanks,
> Abner
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Chang, Abner (HPS SW/FW Technologist)
> *Sent:* Friday, March 11, 2022 1:48 PM
> *To:* Wenyi Xie <xiewenyi2 at huawei.com>; devel at edk2.groups.io <devel at edk2.groups.io>; Wang, Nickle (Server BIOS) <nickle.wang at hpe.com>
> *Cc:* songdongkuang at huawei.com <songdongkuang at huawei.com>
> *Subject:* RE: [PATCH EDK2 v1 1/1] RedfishPkg: fix memory leak issue
>
> Thanks for catching this.
>
> Reviewed-by: Abner Chang <abner.chang at hpe.com>
>
>> -----Original Message-----
>> From: Wenyi Xie <xiewenyi2 at huawei.com>
>> Sent: Thursday, March 10, 2022 7:26 PM
>> To: devel at edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>> <abner.chang at hpe.com>; Wang, Nickle (Server BIOS)
>> <nickle.wang at hpe.com>
>> Cc: songdongkuang at huawei.com; xiewenyi2 at huawei.com
>> Subject: [PATCH EDK2 v1 1/1] RedfishPkg: fix memory leak issue
>>
>> The calloc memory is not free when function collectionEvalOp
>> return in the halfway.
>>
>> Cc: Abner Chang <abner.chang at hpe.com>
>> Cc: Nickle Wang <nickle.wang at hpe.com>
>> Signed-off-by: Wenyi Xie <xiewenyi2 at huawei.com>
>> ---
>> RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c | 16
>> +++++++---------
>> 1 file changed, 7 insertions(+), 9 deletions(-)
>>
>> diff --git
>> a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c
>> b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c
>> index 3f2b83e834d0..6c6e2246abe3 100644
>> --- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c
>> +++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c
>> @@ -620,6 +620,7 @@ collectionEvalOp (
>> if (((*StatusCode == NULL) && (members == NULL)) ||
>> ((*StatusCode != NULL) && ((**StatusCode < HTTP_STATUS_200_OK) ||
>> (**StatusCode > HTTP_STATUS_206_PARTIAL_CONTENT))))
>> {
>> + free (valid);
>> return members;
>> }
>>
>> @@ -633,6 +634,7 @@ collectionEvalOp (
>> if (((*StatusCode == NULL) && (tmp == NULL)) ||
>> ((*StatusCode != NULL) && ((**StatusCode < HTTP_STATUS_200_OK) ||
>> (**StatusCode > HTTP_STATUS_206_PARTIAL_CONTENT))))
>> {
>> + free (valid);
>> return tmp;
>> }
>>
>> @@ -658,19 +660,15 @@ collectionEvalOp (
>>
>> cleanupPayload (members);
>> if (validCount == 0) {
>> - free (valid);
>> - return NULL;
>> - }
>> -
>> - if (validCount == 1) {
>> + ret = NULL;
>> + } else if (validCount == 1) {
>> ret = valid[0];
>> - free (valid);
>> - return ret;
>> } else {
>> ret = createCollection (payload->service, validCount, valid);
>> - free (valid);
>> - return ret;
>> }
>> +
>> + free (valid);
>> + return ret;
>> }
>>
>> static redfishPayload *
>> --
>> 2.20.1.windows.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87461): https://edk2.groups.io/g/devel/message/87461
Mute This Topic: https://groups.io/mt/89683950/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list