[edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics

[Michael D Kinney]

Hi Gerd,

Thanks for working on this.  I raised this topic in the new TianoCore build and CI 
meeting yesterday because the intrinsic libs are closely tied to the toolchains
supported by TianoCore.

I agree with the concept of moving the compiler intrinsics to a library in the MdePkg.

+ Sean Brogan

Sean mentioned that he has some addition work on intrinsic libs for Visual Studio
toolchains.  It would be good to see if this set of changes is aligned with those
efforts.

I see a few items that might be good to clean up at some point
* fltused should go into its own file.  Not related to the strcmp() API
* I see size_t defined in multiple places using different mappings.  Would be good to 
  define that in a single location.

Best regards,

Mike


> -----Original Message-----
> From: Gerd Hoffmann <kraxel at redhat.com>
> Sent: Tuesday, March 15, 2022 5:23 AM
> To: devel at edk2.groups.io
> Cc: Lu, Xiaoyu1 <xiaoyu1.lu at intel.com>; Feng, Bob C <bob.c.feng at intel.com>; Rebecca Cran <rebecca at bsdio.com>; James
> Bottomley <jejb at linux.ibm.com>; Sami Mujawar <Sami.Mujawar at arm.com>; Justen, Jordan L <jordan.l.justen at intel.com>; Aktas,
> Erdem <erdemaktas at google.com>; Yao, Jiewen <jiewen.yao at intel.com>; Supreeth Venkatesh <supreeth.venkatesh at arm.com>; Boeuf,
> Sebastien <sebastien.boeuf at intel.com>; Gao, Zhichao <zhichao.gao at intel.com>; Liu, Zhiguang <zhiguang.liu at intel.com>; Maciej
> Rabeda <maciej.rabeda at linux.intel.com>; Ma, Maurice <maurice.ma at intel.com>; Andrew Fish <afish at apple.com>; Ard Biesheuvel
> <ardb+tianocore at kernel.org>; Tom Lendacky <thomas.lendacky at amd.com>; Peter Grehan <grehan at freebsd.org>; Sean Brogan
> <sean.brogan at microsoft.com>; Jiang, Guomin <guomin.jiang at intel.com>; Bret Barkelew <Bret.Barkelew at microsoft.com>; Chen,
> Christine <yuwei.chen at intel.com>; You, Benjamin <benjamin.you at intel.com>; Schaefer, Daniel <daniel.schaefer at hpe.com>; Gao,
> Liming <gaoliming at byosoft.com.cn>; Kinney, Michael D <michael.d.kinney at intel.com>; Xu, Wei6 <wei6.xu at intel.com>; Wang, Jian
> J <jian.j.wang at intel.com>; Wu, Jiaxin <jiaxin.wu at intel.com>; Fu, Siyuan <siyuan.fu at intel.com>; Dong, Guo
> <guo.dong at intel.com>; kilian_kegel at hotmail.com; Chang, Abner <abner.chang at hpe.com>; Oliver Steffen <osteffen at redhat.com>;
> Leif Lindholm <quic_llindhol at quicinc.com>; Brijesh Singh <brijesh.singh at amd.com>; Xu, Min M <min.m.xu at intel.com>; Ni, Ray
> <ray.ni at intel.com>; Alexei Fedorov <Alexei.Fedorov at arm.com>; Julien Grall <julien at xen.org>; Wang, Nickle
> <nickle.wang at hpe.com>; Pawel Polawski <ppolawsk at redhat.com>; Anthony Perard <anthony.perard at citrix.com>
> Subject: Re: [PATCH 0/3] [RFC] consolidate compiler intrinsics
> 
> On Tue, Mar 01, 2022 at 08:18:17AM +0100, Gerd Hoffmann wrote:
> > This is an attept to start cleaning up the messy compiler intrinsics
> > situation.  Today we don't have a core intrinsics library, resulting
> > in everybody creating their own.  ArmPkg has one, CryptoPkg has one.
> > I'm sure there are many more.
> >
> > This doesn't make sense.  Given we can't avoid compiler intrinsics (as
> > proven by the existence of those libraries) we should better have them
> > as core library so we have to maintain a single version only.
> >
> > Given we already have BaseIoLibIntrinsic in MdePkg we can place the
> > compiler intrinsics there too.  This little patch series does just that:
> > It moves over the existing ArmPkg intrinsics, fixes them to build on
> > non-arm too, and adds additional bits from the CryptoPkg intrinsics.
> 
> Ping.  How go forward with this?  I've posted it as RFC because
> I expected a more controversial discussion.  But seems everybody
> agrees this is a step into the right direction.
> 
> So just merge this as-is?
> 
> Yes, it passed CI (https://github.com/tianocore/edk2/pull/2542).
> 
> take care,
>   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87602): https://edk2.groups.io/g/devel/message/87602
Mute This Topic: https://groups.io/mt/89471210/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-