[edk2-devel] [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
Samer El-Haj-Mahmoud
samer.el-haj-mahmoud at arm.com
Thu Mar 17 13:25:41 UTC 2022
Thanks Sami and Jiewen.
I will bring this to ASWG attention to confirm the change.
> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao at intel.com>
> Sent: Thursday, March 17, 2022 9:23 AM
> To: Sami Mujawar <Sami.Mujawar at arm.com>; Xu, Min M
> <min.m.xu at intel.com>; devel at edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming
> <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>; Wang,
> Jian J <jian.j.wang at intel.com>; Lu, Ken <ken.lu at intel.com>; Gerd Hoffmann
> <kraxel at redhat.com>; nd <nd at arm.com>; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud at arm.com>; Thanu Rangarajan
> <Thanu.Rangarajan at arm.com>
> Subject: RE: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
>
> Thanks to remind me.
>
> I uploaded version 2 in the same mantis.
>
> Thank you
> Yao Jiewen
>
> > -----Original Message-----
> > From: Sami Mujawar <Sami.Mujawar at arm.com>
> > Sent: Thursday, March 17, 2022 9:10 PM
> > To: Yao, Jiewen <jiewen.yao at intel.com>; Xu, Min M
> <min.m.xu at intel.com>;
> > devel at edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming
> > <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>;
> Wang,
> > Jian J <jian.j.wang at intel.com>; Lu, Ken <ken.lu at intel.com>; Gerd Hoffmann
> > <kraxel at redhat.com>; nd <nd at arm.com>; Samer El-Haj-Mahmoud
> <Samer.El-
> > Haj-Mahmoud at arm.com>; Thanu Rangarajan
> <Thanu.Rangarajan at arm.com>
> > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
> >
> > Hi Jiewen,
> >
> > I was informed there is an ASWG ECR
> > https://mantis.uefi.org/mantis/view.php?id=2177 for TDEL. I can see the
> > content has been approved for ACPI 6.5.
> >
> > Do you plan to update this ECR to reflect the changes for CCEL or this would
> be
> > a separate request?
> >
> > Regards,
> >
> > Sami Mujawar
> >
> > On 10/03/2022, 10:27, "Sami Mujawar" <Sami.Mujawar at arm.com> wrote:
> >
> > Hi Jiewen,
> >
> > Please find my response inline marked [SAMI].
> >
> > Regards,
> >
> > Sami Mujawar
> >
> > On 10/03/2022, 05:49, "Yao, Jiewen" <jiewen.yao at intel.com> wrote:
> >
> > HI Sami
> > I think it is OK to update signature to `CCEL`. That means it will be
> applicable
> > for other CC, right?
> > [SAMI] Yes, the same table can then be used by other CC.
> >
> > Then, I recommend we add CcType there.
> >
> > typedef struct {
> > EFI_ACPI_DESCRIPTION_HEADER Header;
> > EFI_CC_TYPE CcType; <== new field.
> > UINT16 Rsvd;
> > UINT64 Laml;
> > UINT64 Lasa;
> > } EFI_CC_EVENTLOG_ACPI_TABLE;
> >
> > Do you agree?
> > [SAMI] Agree, the above suggestion looks good to me.
> >
> > Thank you
> > Yao Jiewen
> >
> > > -----Original Message-----
> > > From: Sami Mujawar <sami.mujawar at arm.com>
> > > Sent: Wednesday, March 9, 2022 11:35 PM
> > > To: Xu, Min M <min.m.xu at intel.com>; devel at edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming
> > > <gaoliming at byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu at intel.com>;
> > Yao,
> > > Jiewen <jiewen.yao at intel.com>; Wang, Jian J
> <jian.j.wang at intel.com>;
> > Lu, Ken
> > > <ken.lu at intel.com>; Gerd Hoffmann <kraxel at redhat.com>; nd
> > <nd at arm.com>;
> > > Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>;
> > > thanu.rangarajan at arm.com
> > > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI
> > Table
> > >
> > > Hi Min,
> > >
> > > Thank you for this patch.
> > >
> > > Please find my response inline marked [SAMI].
> > >
> > > Regards,
> > >
> > > Sami Mujawar
> > >
> > >
> > > On 02/03/2022 12:28 AM, Min Xu wrote:
> > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
> > > >
> > > > TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass
> the
> > > > event-log information. The event log created by the TD owner
> contains
> > > > the hashes to reconstruct the MRTD and RTMR registers.
> > > >
> > > > Please refer to Sec 4.3.3 in blow link:
> > > >
> > https://www.intel.com/content/dam/develop/external/us/en/documents/
> > > > intel-tdx-guest-hypervisor-communication-interface-1.0-344426-
> > 002.pdf
> > > >
> > > > Cc: Michael D Kinney <michael.d.kinney at intel.com>
> > > > Cc: Liming Gao <gaoliming at byosoft.com.cn>
> > > > Cc: Zhiguang Liu <zhiguang.liu at intel.com>
> > > > Cc: Jiewen Yao <jiewen.yao at intel.com>
> > > > Cc: Jian J Wang <jian.j.wang at intel.com>
> > > > Cc: Ken Lu <ken.lu at intel.com>
> > > > Cc: Sami Mujawar <sami.mujawar at arm.com>
> > > > Cc: Gerd Hoffmann <kraxel at redhat.com>
> > > > Signed-off-by: Min Xu <min.m.xu at intel.com>
> > > > ---
> > > > MdePkg/Include/Protocol/CcMeasurement.h | 20
> > ++++++++++++++++++++
> > > > 1 file changed, 20 insertions(+)
> > > >
> > > > diff --git a/MdePkg/Include/Protocol/CcMeasurement.h
> > > b/MdePkg/Include/Protocol/CcMeasurement.h
> > > > index 83eaafaf10a6..86de226c1d82 100644
> > > > --- a/MdePkg/Include/Protocol/CcMeasurement.h
> > > > +++ b/MdePkg/Include/Protocol/CcMeasurement.h
> > > > @@ -307,4 +307,24 @@ extern EFI_GUID
> gEfiCcFinalEventsTableGuid;
> > > >
> > > > extern EFI_GUID gCcEventEntryHobGuid;
> > > >
> > > > +//
> > > > +// Define the CC Measure EventLog ACPI Table
> > > > +//
> > > > +#pragma pack(1)
> > > > +
> > > > +typedef struct {
> > > > + EFI_ACPI_DESCRIPTION_HEADER Header;
> > > > + UINT32 Rsvd;
> > > > + UINT64 Laml;
> > > > + UINT64 Lasa;
> > > > +} EFI_CC_EVENTLOG_ACPI_TABLE;
> > > > +
> > > > +#pragma pack()
> > > > +
> > > > +//
> > > > +// Define the signature and revision of CC Measurement EventLog
> ACPI
> > Table
> > > for Td guest
> > > > +//
> > > > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_SIGNATURE
> > SIGNATURE_32('T',
> > > 'D', 'E', 'L')
> > > > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_REVISION 1
> > > [SAMI] I can see that the above macros have the _TD_ infix. Is the
> > > intention here that each architecture shall define its own signature
> and
> > > revision?
> > > Would it be possible to make the signature generic across
> architectures,
> > > e.g. "SIGNATURE_32('C', 'C', 'E', 'L')" ?
> > > [/SAMI]
> > > > +
> > > > #endif
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87664): https://edk2.groups.io/g/devel/message/87664
Mute This Topic: https://groups.io/mt/89491522/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list