回复: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics

[gaoliming]

Gerd:
  I suggest to submit the different BZs for those tasks. This patch set is
the first stage. Future enhancement can be added later.

  If no more comment for the first stage, this patch set can be merged
first.

Thanks
Liming
> -----邮件原件-----
> 发件人: Gerd Hoffmann <kraxel at redhat.com>
> 发送时间: 2022年3月16日 17:46
> 收件人: devel at edk2.groups.io; michael.d.kinney at intel.com
> 抄送: Sean Brogan <sean.brogan at microsoft.com>; Lu, Xiaoyu1
> <xiaoyu1.lu at intel.com>; Feng, Bob C <bob.c.feng at intel.com>; Rebecca Cran
> <rebecca at bsdio.com>; James Bottomley <jejb at linux.ibm.com>; Sami
> Mujawar <Sami.Mujawar at arm.com>; Justen, Jordan L
> <jordan.l.justen at intel.com>; Aktas, Erdem <erdemaktas at google.com>; Yao,
> Jiewen <jiewen.yao at intel.com>; Supreeth Venkatesh
> <supreeth.venkatesh at arm.com>; Boeuf, Sebastien
> <sebastien.boeuf at intel.com>; Gao, Zhichao <zhichao.gao at intel.com>; Liu,
> Zhiguang <zhiguang.liu at intel.com>; Maciej Rabeda
> <maciej.rabeda at linux.intel.com>; Ma, Maurice <maurice.ma at intel.com>;
> Andrew Fish <afish at apple.com>; Ard Biesheuvel
> <ardb+tianocore at kernel.org>; Tom Lendacky <thomas.lendacky at amd.com>;
> Peter Grehan <grehan at freebsd.org>; Jiang, Guomin
> <guomin.jiang at intel.com>; Bret Barkelew <Bret.Barkelew at microsoft.com>;
> Chen, Christine <yuwei.chen at intel.com>; You, Benjamin
> <benjamin.you at intel.com>; Schaefer, Daniel <daniel.schaefer at hpe.com>;
> Gao, Liming <gaoliming at byosoft.com.cn>; Xu, Wei6 <wei6.xu at intel.com>;
> Wang, Jian J <jian.j.wang at intel.com>; Wu, Jiaxin <jiaxin.wu at intel.com>;
Fu,
> Siyuan <siyuan.fu at intel.com>; Dong, Guo <guo.dong at intel.com>;
> kilian_kegel at hotmail.com; Chang, Abner <abner.chang at hpe.com>; Oliver
> Steffen <osteffen at redhat.com>; Leif Lindholm <quic_llindhol at quicinc.com>;
> Brijesh Singh <brijesh.singh at amd.com>; Xu, Min M <min.m.xu at intel.com>;
> Ni, Ray <ray.ni at intel.com>; Alexei Fedorov <Alexei.Fedorov at arm.com>;
> Julien Grall <julien at xen.org>; Wang, Nickle <nickle.wang at hpe.com>; Pawel
> Polawski <ppolawsk at redhat.com>; Anthony Perard
> <anthony.perard at citrix.com>
> 主题: Re: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics
> 
> On Tue, Mar 15, 2022 at 03:27:58PM +0000, Michael D Kinney wrote:
> > Hi Gerd,
> >
> > Thanks for working on this.  I raised this topic in the new TianoCore
build
> and CI
> > meeting yesterday because the intrinsic libs are closely tied to the
> toolchains
> > supported by TianoCore.
> >
> > I agree with the concept of moving the compiler intrinsics to a library
in the
> MdePkg.
> >
> > + Sean Brogan
> >
> > Sean mentioned that he has some addition work on intrinsic libs for
Visual
> Studio
> > toolchains.  It would be good to see if this set of changes is aligned
with
> those
> > efforts.
> 
> Having a single place where all compiler intrinsics are located should
> simplify this kind of changes.
> 
> > I see a few items that might be good to clean up at some point
> > * fltused should go into its own file.  Not related to the strcmp() API
> > * I see size_t defined in multiple places using different mappings.
Would
> be good to
> >   define that in a single location.
> 
> Yes, sure.  Both are valid points.
> 
> I see this series as first step, consolidating the existing code in a
> singe place with (almost) no actual code changes.  There surely will be
> incremental improvements and cleanups later on.  I will need a few more
> intrinsic functions when moving edk2 to openssl 3.0 for example.
> 
> take care,
>   Gerd





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87720): https://edk2.groups.io/g/devel/message/87720
Mute This Topic: https://groups.io/mt/89859655/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-