回复: [edk2-devel] [PATCH v2 1/1] Basetools: fix gcc workaround

[gaoliming]

Christine:
  Can you try the option -Wno-unknown-warning to see whether it disables the
warning about an unrecognized command line option?

Thanks
Liming
> -----邮件原件-----
> 发件人: Chen, Christine <yuwei.chen at intel.com>
> 发送时间: 2022年3月31日 10:47
> 收件人: devel at edk2.groups.io; Chen, Christine <yuwei.chen at intel.com>;
> Gerd Hoffmann <kraxel at redhat.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>; Sean Brogan <sean.brogan at microsoft.com>;
> Gao, Liming <gaoliming at byosoft.com.cn>; Shi, Steven
> <steven.shi at intel.com>; Feng, Bob C <bob.c.feng at intel.com>
> 抄送: Rebecca Cran <rebecca at bsdio.com>; Pawel Polawski
> <ppolawsk at redhat.com>; Oliver Steffen <osteffen at redhat.com>
> 主题: RE: [edk2-devel] [PATCH v2 1/1] Basetools: fix gcc workaround
> 
> Since the gcc12 has the incompatible change from GCC5.4, I'd also suggest
we
> could create a new TOOL CHAIN for gcc12.
> The error reports I collected show in gcc5.4 ,
"-Wno-error=stringop-overflow"
> is an unrecognized command line option which is available in gcc12.
> 
> Thanks,
> Christine (Yuwei)
> > -----Original Message-----
> > From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Yuwei
> > Chen
> > Sent: Thursday, March 31, 2022 8:51 AM
> > To: Gerd Hoffmann <kraxel at redhat.com>; devel at edk2.groups.io
> > Cc: Feng, Bob C <bob.c.feng at intel.com>; Rebecca Cran
> > <rebecca at bsdio.com>; Pawel Polawski <ppolawsk at redhat.com>; Oliver
> > Steffen <osteffen at redhat.com>; Gao, Liming <gaoliming at byosoft.com.cn>
> > Subject: Re: [edk2-devel] [PATCH v2 1/1] Basetools: fix gcc workaround
> >
> > Hi Hoffmann,
> >
> > I received some reports that some platforms are using gcc5.4. With this
> patch,
> > these platform builds are still broken.
> > Would you like to revert the original commits?
> >
> > Thanks,
> > Christine (Yuwei)
> >
> > > -----Original Message-----
> > > From: Gerd Hoffmann <kraxel at redhat.com>
> > > Sent: Tuesday, March 29, 2022 4:38 PM
> > > To: devel at edk2.groups.io
> > > Cc: Feng, Bob C <bob.c.feng at intel.com>; Rebecca Cran
> > > <rebecca at bsdio.com>; Pawel Polawski <ppolawsk at redhat.com>; Oliver
> > > Steffen <osteffen at redhat.com>; Chen, Christine
> > <yuwei.chen at intel.com>;
> > > Gao, Liming <gaoliming at byosoft.com.cn>; Gerd Hoffmann
> > > <kraxel at redhat.com>
> > > Subject: [PATCH v2 1/1] Basetools: fix gcc workaround
> > >
> > > Apply the workaround only in case the compiler is gcc.
> > > Fixes builds with clang.
> > >
> > > Fixes: 22130dcd98b4 ("Basetools: turn off gcc12 warning")
> > > Reported-by: Rebecca Cran <rebecca at bsdio.com>
> > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> > > ---
> > >  BaseTools/Source/C/DevicePath/GNUmakefile | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile
> > > b/BaseTools/Source/C/DevicePath/GNUmakefile
> > > index b05d2bddfa68..6323e7355cc8 100644
> > > --- a/BaseTools/Source/C/DevicePath/GNUmakefile
> > > +++ b/BaseTools/Source/C/DevicePath/GNUmakefile
> > > @@ -13,8 +13,10 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o
> > > DevicePathFromText.o  DevicePathUtili
> > >
> > >  include $(MAKEROOT)/Makefiles/app.makefile
> > >
> > > +ifneq ($(CXX), llvm)
> > >  # gcc 12 trips over device path handling  BUILD_CFLAGS += -Wno-
> > > error=stringop-overflow
> > > +endif
> > >
> > >  LIBS = -lCommon
> > >  ifeq ($(CYGWIN), CYGWIN)
> > > --
> > > 2.35.1
> >
> >
> >
> > 
> >





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88284): https://edk2.groups.io/g/devel/message/88284
Mute This Topic: https://groups.io/mt/90149552/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-