[edk2-devel] [PATCH V2 2/5] CryptoPkg: Separate auto-generated openssl config and edk2 openssl config

[yi1 li]

Just for convenience.
There are too many places need to configure, so I think putting all the configuration options close together, all in process_file.pl, will be more clear to user ;)

Thank you,
Yi 


-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Gerd Hoffmann
Sent: Tuesday, May 10, 2022 6:50 PM
To: Li, Yi1 <yi1.li at intel.com>
Cc: devel at edk2.groups.io; Yao, Jiewen <jiewen.yao at intel.com>; Wang, Jian J <jian.j.wang at intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu at intel.com>; Jiang, Guomin <guomin.jiang at intel.com>
Subject: Re: [edk2-devel] [PATCH V2 2/5] CryptoPkg: Separate auto-generated openssl config and edk2 openssl config

On Tue, May 10, 2022 at 12:40:13PM +0800, Yi Li wrote:
> Move auto-generated openssl config to opensslconf_generated.h,  And 
> opensslconf.h will contain both edk2 conditional openssl  feature and 
> opensslconf_generated.h.
> Will make two part more clear.
> New conditional feture code in opensslconf.h will look like:
> 
> /* Autogenerated conditional openssl feature list starts here */ 
> [.....]
> /* Autogenerated conditional openssl feature list ends here */

Why generate opensslconf.h at all?  I think the content doesn't depend on the openssl submodule sources, so there is no good reason to take the extra indirection and write it with process_files.pl.  Just commit it ;)

take care,
  Gerd








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89654): https://edk2.groups.io/g/devel/message/89654
Mute This Topic: https://groups.io/mt/91006616/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-