[edk2-devel] [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper name

Sunil V L sunilvl at ventanamicro.com
Fri Nov 11 11:21:06 UTC 2022


REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4143

Fix the name of InternalSyncCompareExchange64() function.

Signed-off-by: Sunil V L <sunilvl at ventanamicro.com>
Reported-by: Zhihao Li <zhihao.li at intel.com>
Tested-by: Zhihao Li <zhihao.li at intel.com>

Cc: Michael D Kinney <michael.d.kinney at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu at intel.com>
Cc: Daniel Schaefer <git at danielschaefer.me>
---
 .../Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 2 +-
 .../Library/BaseSynchronizationLib/RiscV64/Synchronization.S  | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf b/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
index dd66ec1d0370..88dfb880fea9 100755
--- a/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
+++ b/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
@@ -81,7 +81,7 @@ [Sources.AARCH64]
 
 [Sources.RISCV64]
   Synchronization.c
-  RiscV64/Synchronization.S
+  RiscV64/Synchronization.S     | GCC
 
 [Sources.LOONGARCH64]
   Synchronization.c
diff --git a/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S b/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S
index bac80d687168..f287ef38f651 100644
--- a/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S
+++ b/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S
@@ -36,8 +36,6 @@ exit:
     mv    a0, a3
     ret
 
-.global ASM_PFX(InternalSyncCompareExchange64)
-
 //
 // Compare and xchange a 64-bit value.
 //
@@ -45,7 +43,7 @@ exit:
 // @param a1 : Compare value.
 // @param a2 : Exchange value.
 //
-ASM_PFX (SyncCompareExchange64):
+ASM_PFX (InternalSyncCompareExchange64):
     lr.d  a3, (a0)       // Load the value from a0 and make
                          // the reservation of address.
     bne   a3, a1, exit
-- 
2.38.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96301): https://edk2.groups.io/g/devel/message/96301
Mute This Topic: https://groups.io/mt/94956338/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list