[edk2-devel] [PATCH 3/4] OvmfPkg/IntelTdx: Enable separate-fv in IntelTdx/IntelTdxX64.fdf

[Gerd Hoffmann]

  Hi,

> So we separate DXEFV into 2 FVs: DXEFV and NCCFV. All the drivers which
> are not needed by a Confidential Computing guest are moved from DXEFV
> to NCCFV.

>  INF  OvmfPkg/VirtioBlkDxe/VirtioBlk.inf
> -INF  OvmfPkg/VirtioScsiDxe/VirtioScsi.inf

Why keep virtio-blk in DXEFV but drop virtio-scsi?

> -INF  MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
> -INF  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf

These are needed too for virtio-scsi.

> +INF  FatPkg/EnhancedFatDxe/Fat.inf
> +INF  ShellPkg/Application/Shell/Shell.inf

Why add the shell to DXEFV?  Shouldn't this go to NCCFV?

Also please wrap this into '!if $(BUILD_SHELL) == TRUE' for
consistency with the other ovmf build variants.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96400): https://edk2.groups.io/g/devel/message/96400
Mute This Topic: https://groups.io/mt/95038268/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-