[edk2-devel] [PATCH v2 5/6] IntelFsp2WrapperPkg: Add CI YAML file
Chiu, Chasel
chasel.chiu at intel.com
Wed Oct 5 01:27:54 UTC 2022
Hi Michael Kubacki,
Please help to review below patch series which will resolve the duplicate library header in DEC issue.
Thanks,
Chasel
https://edk2.groups.io/g/devel/message/94725
https://edk2.groups.io/g/devel/message/94726
https://edk2.groups.io/g/devel/message/94727
> -----Original Message-----
> From: Michael Kubacki <mikuback at linux.microsoft.com>
> Sent: Tuesday, October 4, 2022 9:22 AM
> To: Kinney, Michael D <michael.d.kinney at intel.com>; devel at edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Zeng, Star <star.zeng at intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 5/6] IntelFsp2WrapperPkg: Add CI YAML file
>
> Hi Mike,
>
> I agree that it is a design issue and I had a patch for it in the v1 series. It did not
> fix the issue but took a different approach to work around it for CI enabling.
>
> See the following conversation between Chasel and I regarding that patch:
> https://edk2.groups.io/g/devel/message/93319
>
> Since it was described as intended, I removed made that change in the v2 series.
>
> I'm happy to turn the write up into a bug, depending on what maintainers want
> to do.
>
> For now I plan to submit this series as-is to get out of the way and let the
> maintainers handle it.
>
> Regards,
> Michael
>
> On 10/4/2022 12:01 PM, Kinney, Michael D wrote:
> > Michael,
> >
> > This looks like a design issue in the IntelFsp2WrapperPkg for 2 lib
> > classes to point to the same include file.
> >
> > Do you have a recommended fix for this issue?
> >
> > I am ok with this YAML file that ignores the error, but I think a new
> > issue should be opened to fix this package to follow the standard
> > package rules.
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of
> >> Michael Kubacki
> >> Sent: Thursday, September 15, 2022 11:55 AM
> >> To: devel at edk2.groups.io
> >> Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L
> >> <nathaniel.l.desimone at intel.com>; Zeng, Star <star.zeng at intel.com>
> >> Subject: [edk2-devel] [PATCH v2 5/6] IntelFsp2WrapperPkg: Add CI YAML
> >> file
> >>
> >> From: Michael Kubacki <michael.kubacki at microsoft.com>
> >>
> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048
> >>
> >> Adds IntelFsp2WrapperPkg to the list of supported build packages for
> >> edk2 CI and defines an initial set of CI configuration options.
> >>
> >> Adds a special case for the Library Class check CI plugin to ignore
> >> FspWrapperPlatformMultiPhaseLib with an explanatory comment.
> >>
> >> Cc: Chasel Chiu <chasel.chiu at intel.com>
> >> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> >> Cc: Star Zeng <star.zeng at intel.com>
> >> Signed-off-by: Michael Kubacki <michael.kubacki at microsoft.com>
> >> ---
> >> .pytool/CISettings.py | 1 +
> >> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 96
> ++++++++++++++++++++
> >> 2 files changed, 97 insertions(+)
> >>
> >> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> >> 0205c26a58f8..d9a260784e59 100644
> >> --- a/.pytool/CISettings.py
> >> +++ b/.pytool/CISettings.py
> >> @@ -55,6 +55,7 @@ class Settings(CiBuildSettingsManager,
> UpdateSettingsManager, SetupSettingsManag
> >> "DynamicTablesPkg",
> >> "EmulatorPkg",
> >> "IntelFsp2Pkg",
> >> + "IntelFsp2WrapperPkg",
> >> "MdePkg",
> >> "MdeModulePkg",
> >> "NetworkPkg",
> >> diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> >> b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> >> new file mode 100644
> >> index 000000000000..55f28d90870c
> >> --- /dev/null
> >> +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> >> @@ -0,0 +1,96 @@
> >> +## @file
> >> +# Core CI configuration for IntelFsp2WrapperPkg # # Copyright (c)
> >> +Microsoft Corporation # # SPDX-License-Identifier:
> >> +BSD-2-Clause-Patent ## {
> >> + ## options defined .pytool/Plugin/LicenseCheck
> >> + "LicenseCheck": {
> >> + "IgnoreFiles": []
> >> + },
> >> +
> >> + "EccCheck": {
> >> + ## Exception sample looks like below:
> >> + ## "ExceptionList": [
> >> + ## "<ErrorID>", "<KeyWord>"
> >> + ## ]
> >> + "ExceptionList": [
> >> + ],
> >> + ## Both file path and directory path are accepted.
> >> + "IgnoreFiles": []
> >> + },
> >> +
> >> + ## options defined .pytool/Plugin/CompilerPlugin
> >> + "CompilerPlugin": {
> >> + "DscPath": "IntelFsp2WrapperPkg.dsc"
> >> + },
> >> +
> >> + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
> >> + "HostUnitTestCompilerPlugin": {
> >> + "DscPath": "" # Don't support this test
> >> + },
> >> +
> >> + ## options defined .pytool/Plugin/CharEncodingCheck
> >> + "CharEncodingCheck": {
> >> + "IgnoreFiles": []
> >> + },
> >> +
> >> + ## options defined .pytool/Plugin/DependencyCheck
> >> + "DependencyCheck": {
> >> + "AcceptableDependencies": [
> >> + "IntelFsp2Pkg/IntelFsp2Pkg.dec",
> >> + "IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec",
> >> + "MdeModulePkg/MdeModulePkg.dec",
> >> + "MdePkg/MdePkg.dec",
> >> + "SecurityPkg/SecurityPkg.dec",
> >> + "UefiCpuPkg/UefiCpuPkg.dec"
> >> + ],
> >> + # For host based unit tests
> >> + "AcceptableDependencies-HOST_APPLICATION":[
> >> + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
> >> + ],
> >> + # For UEFI shell based apps
> >> + "AcceptableDependencies-UEFI_APPLICATION":[],
> >> + "IgnoreInf": []
> >> + },
> >> +
> >> + ## options defined .pytool/Plugin/DscCompleteCheck
> >> + "DscCompleteCheck": {
> >> + "IgnoreInf": [""],
> >> + "DscPath": "IntelFsp2WrapperPkg.dsc"
> >> + },
> >> +
> >> + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
> >> + "HostUnitTestDscCompleteCheck": {
> >> + "IgnoreInf": [""],
> >> + "DscPath": "" # Don't support this test
> >> + },
> >> +
> >> + ## options defined .pytool/Plugin/GuidCheck
> >> + "GuidCheck": {
> >> + "IgnoreGuidName": [],
> >> + "IgnoreGuidValue": [],
> >> + "IgnoreFoldersAndFiles": [],
> >> + "IgnoreDuplicates": [],
> >> + },
> >> +
> >> + ## options defined .pytool/Plugin/LibraryClassCheck
> >> + "LibraryClassCheck": {
> >> + "IgnoreLibraryClass": [
> >> + # This header file contains a small function in a separate library so
> platforms
> >> + # do not have to override the whole main library instance.
> >> + "FspWrapperPlatformMultiPhaseLib"
> >> + ]
> >> + },
> >> +
> >> + ## options defined .pytool/Plugin/SpellCheck
> >> + "SpellCheck": {
> >> + "AuditOnly": True, # Fails right now with over 270 errors
> >> + "IgnoreFiles": [], # use gitignore syntax to ignore errors in
> matching files
> >> + "ExtendWords": [], # words to extend to the dictionary for this
> package
> >> + "IgnoreStandardPaths": [], # Standard Plugin defined paths that should
> be ignore
> >> + "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards
> supported)
> >> + }
> >> +}
> >> --
> >> 2.28.0.windows.1
> >>
> >>
> >>
> >> -=-=-=-=-=-=
> >> Groups.io Links: You receive all messages sent to this group.
> >> View/Reply Online (#93864):
> >> https://edk2.groups.io/g/devel/message/93864
> >> Mute This Topic: https://groups.io/mt/93707371/1643496
> >> Group Owner: devel+owner at edk2.groups.io
> >> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> >> [michael.d.kinney at intel.com] -=-=-=-=-=-=
> >>
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94729): https://edk2.groups.io/g/devel/message/94729
Mute This Topic: https://groups.io/mt/93707371/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list