[edk2-devel] [PATCH v2 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot
Rebecca Cran
quic_rcran at quicinc.com
Fri Oct 7 13:12:37 UTC 2022
Ah, dangit! I completely forgot to run uncrustify.
I'll send out a v3.
--
Rebecca Cran
On 10/7/22 06:34, Sami Mujawar wrote:
> Hi Rebecca,
>
> Thank you for this patch.
>
> On Fri, Oct 7, 2022 at 04:38 AM, Rebecca Cran wrote:
>
> + CharCount = AsciiSPrint (
> + Buffer,
> + sizeof (Buffer),
> + "UEFI firmware (version %s built at %a on %a)\n\r",
> + (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString),
> + __TIME__,
> + __DATE__
> + );
>
> Can you check if uncrustify reports any issue with the above, please?
> Other than that this patch looks good to me.
>
> Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>
>
> Regards,
>
> Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94810): https://edk2.groups.io/g/devel/message/94810
Mute This Topic: https://groups.io/mt/94177352/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list