[edk2-devel] [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5

PierreGondois pierre.gondois at arm.com
Mon Oct 10 09:48:16 UTC 2022


+ Ray Ni
+ Zhichao Gao

as the patch wasn't sent to them.

On 10/10/22 11:20, PierreGondois via groups.io wrote:
> From: Pierre Gondois <pierre.gondois at arm.com>
> 
> The ACPI specification updated some terms in accordance with:
> s1.1.1 Principle of Inclusive Terminology
> 
> Update the PCCT parser accordincly with these new terms.
> 
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Zhichao Gao <zhichao.gao at intel.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois at arm.com>
> ---
>   .../UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c   | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
> index 8cffdaaf0716..8ad39090afe3 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
> @@ -146,7 +146,7 @@ ValidatePccDoorbellGas (
>     IN VOID   *Context
>     )
>   {
> -  // For slave subspaces this field is optional, if not present the field
> +  // For responder subspaces this field is optional, if not present the field
>     // should just contain zeros.
>     if (*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) {
>       if (IsZeroBuffer (
> @@ -214,7 +214,7 @@ ValidatePccErrStatusGas (
>     IN VOID   *Context
>     )
>   {
> -  // This field is ignored by the OSPM on slave channels.
> +  // This field is ignored by the OSPM on responder channels.
>     if (*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) {
>       return;
>     }
> @@ -237,7 +237,7 @@ ValidatePlatInterrupt (
>     IN VOID   *Context
>     )
>   {
> -  // If a slave subspace is present in the PCCT, then the global Platform
> +  // If a responder subspace is present in the PCCT, then the global Platform
>     // Interrupt flag must be set to 1.
>     if ((*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) &&
>         ((*PccGlobalFlags & EFI_ACPI_6_4_PCCT_FLAGS_PLATFORM_INTERRUPT) !=


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94898): https://edk2.groups.io/g/devel/message/94898
Mute This Topic: https://groups.io/mt/94232760/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list