[edk2-devel] [PATCH v2 2/2] RfC: MdeModulePkg: set defaults for FirmwareVersion and FirmwareReleaseDate

[Ard Biesheuvel]

On Tue, 11 Oct 2022 at 12:03, Gerd Hoffmann <kraxel at redhat.com> wrote:
>
> PcdFirmwareVersionString is set to the most recent stable tag name.
> PcdFirmwareReleaseDateString is set to the date of the most recent
> stable tag.
>
> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>

I like this idea in principle, so

Acked-by: Ard Biesheuvel <ardb at kernel.org>

However, I will note that apparently, we couldn't even be bothered to
update the default UEFI revision (still at v2.7 as of today, while the
v2.10 spec has just been released) so I am skeptical whether we will
manage to keep this in sync with reality.


> ---
>  MdeModulePkg/MdeModulePkg.dec | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index 58e6ab004882..933e993359cc 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1730,11 +1730,11 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>
>    ## Null-terminated Unicode string that describes the firmware version.
>    # @Prompt Firmware version string.
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L""|VOID*|0x00010052
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"edk2-stable202208"|VOID*|0x00010052
>
>    ## Null-terminated Unicode string that contains the date the firmware was released
>    # @Prompt Firmware release data string.
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareReleaseDateString|L""|VOID*|0x00010053
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareReleaseDateString|L"26/08/2022"|VOID*|0x00010053
>
>    ## PcdStatusCodeMemorySize is used when PcdStatusCodeUseMemory is set to true.
>    #  (PcdStatusCodeMemorySize * KBytes) is the total taken memory size.<BR><BR>
> --
> 2.37.3
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94987): https://edk2.groups.io/g/devel/message/94987
Mute This Topic: https://groups.io/mt/94255124/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-