[edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic

[Isaac Oram]

Pushed as 66cef08cde..ee8d078e39

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone at intel.com> 
Sent: Tuesday, October 11, 2022 5:05 PM
To: Oram, Isaac W <isaac.w.oram at intel.com>; devel at edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu at intel.com>
Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic

Reviewed-by: Nate DeSimone <nathaniel.l.desimone at intel.com>

-----Original Message-----
From: Oram, Isaac W <isaac.w.oram at intel.com> 
Sent: Monday, October 10, 2022 2:41 PM
To: devel at edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Chiu, Chasel <chasel.chiu at intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic

Fix ACPI table install logic issue introduced by incorrect fix in 4c9b69e590cf81f2b9af9e17243a422798833b0e that prevents some tables from being installed.

Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Chasel Chiu <chasel.chiu at intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram at intel.com>
---
 .../Features/Acpi/AcpiPlatform/AcpiPlatform.c                   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c
index 28117ad460..a884c9745f 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/Acpi
+++ Platform.c
@@ -475,7 +475,7 @@ AcpiPlatformEarlyAcpiTablesInstall (
               // Install the table
               //
               AcpiStatus = AcpiTable->InstallAcpiTable (AcpiTable, CurrentTable, CurrentTable->Length, &TableHandle);
-              if (!EFI_ERROR (AcpiStatus)) {
+              if (EFI_ERROR (AcpiStatus)) {
                 ASSERT_EFI_ERROR (AcpiStatus);
                 return AcpiStatus;
               }
--
2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95018): https://edk2.groups.io/g/devel/message/95018
Mute This Topic: https://groups.io/mt/94246788/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-