[edk2-devel] [PATCH v3 resend 02/11] ArmVirtPkg: do not enable iSCSI driver by default

[Leif Lindholm]

On Wed, Oct 19, 2022 at 11:22:02 +0200, Ard Biesheuvel wrote:
> The iSCSI driver slows down the boot on a pristine variable store flash
> image, as it creates a couple of large EFI non-volatile variables to
> preserve state between boots.
> 
> Since iSCSI boot for VMs is kind of niche anyway, let's default to
> disabled. If someone needs it in their build, they can use the -D build
> command option to re-enable it on the fly.
> 
> Signed-off-by: Ard Biesheuvel <ardb at kernel.org>

Apologies for bikeshedding, but ... I find the listing of tweakable
options in a block at the start of a .dsc very useful.
Could we explicitly set to FALSE instead?

Either way:
Acked-by: Leif Lindholm <quic_llindhol at quicinc.com>

> ---
>  ArmVirtPkg/ArmVirtQemu.dsc       | 1 -
>  ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 9369a88858fd..45c4a8fc84e0 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -40,7 +40,6 @@ [Defines]
>    DEFINE NETWORK_SNP_ENABLE              = FALSE
>    DEFINE NETWORK_TLS_ENABLE              = FALSE
>    DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS  = TRUE
> -  DEFINE NETWORK_ISCSI_ENABLE            = TRUE
>  
>  !if $(NETWORK_SNP_ENABLE) == TRUE
>    !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index 7f7d15d6eee3..66039f07f41b 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -38,7 +38,6 @@ [Defines]
>    DEFINE NETWORK_SNP_ENABLE              = FALSE
>    DEFINE NETWORK_TLS_ENABLE              = FALSE
>    DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS  = TRUE
> -  DEFINE NETWORK_ISCSI_ENABLE            = TRUE
>  
>  !if $(NETWORK_SNP_ENABLE) == TRUE
>    !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
> -- 
> 2.35.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95420): https://edk2.groups.io/g/devel/message/95420
Mute This Topic: https://groups.io/mt/94427012/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-