[edk2-devel] [PATCH 08/14] DynamicTablesPkg: FdtHwInfoParserLib: Remove wrong comment

Sami Mujawar sami.mujawar at arm.com
Wed Oct 26 12:37:33 UTC 2022


Hi Pierre,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar

On 10/10/2022 10:20 am, Pierre.Gondois at arm.com wrote:
> From: Pierre Gondois <pierre.gondois at arm.com>
>
> commit 13136cc3111f ("DynamicTablesPkg: FdtHwInfoParserLib:
> Parse Pmu info")
> adds support for pmu parsing. Thus, remove the wrong comment.
>
> Signed-off-by: Pierre Gondois <pierre.gondois at arm.com>
> ---
>   .../Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c             | 3 ---
>   .../Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h             | 3 ---
>   2 files changed, 6 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> index fb01aa0d19e2..2c72bd0c582e 100644
> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> @@ -785,9 +785,6 @@ GicCPmuNodeParser (
>       UINT32  AffinityFlags;                    // {default = 0}
>     } CM_ARM_GICC_INFO;
>   
> -  The pmu information can be found in the pmu node. There is no support
> -  for now.
> -
>     A parser parses a Device Tree to populate a specific CmObj type. None,
>     one or many CmObj can be created by the parser.
>     The created CmObj are then handed to the parser's caller through the
> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h
> index fd980484a28d..539f39cecb22 100644
> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h
> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h
> @@ -41,9 +41,6 @@
>       UINT32  AffinityFlags;                    // {default = 0}
>     } CM_ARM_GICC_INFO;
>   
> -  The pmu information can be found in the pmu node. There is no support
> -  for now.
> -
>     A parser parses a Device Tree to populate a specific CmObj type. None,
>     one or many CmObj can be created by the parser.
>     The created CmObj are then handed to the parser's caller through the


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95605): https://edk2.groups.io/g/devel/message/95605
Mute This Topic: https://groups.io/mt/94232527/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list