[edk2-devel] [edk2-platforms][PATCH v1 01/02] QemuOpenBoardPkg: Add QemuOpenBoardPkg

[Gerd Hoffmann]

On Sat, Aug 27, 2022 at 02:02:00AM +0200, Théo wrote:
> From: Théo Jehl <theojehl76 at gmail.com>
> 
> QemuOpenBoardPkg adds a MinPlatform port to Qemu x86_64
> It can boots UEFI Linux and Windows, and works on PIIX4 and Q35
> This board port provides a simple starting place for investigating edk2 and
> MinPlatform Arch.
> Currently we implement up to stage 4 of the MinPlatform spec and can boot
> Windows/Linux.

That is a rather short description for a patch of this size.  It
probably makes sense to break that down into smaller pieces and make a
patch series out of it because you can describe the specific pieces much
better then.

I'm not familiar with MinPlatform, just skimmed the manual.  Can't
comment much on those details.

It seems the goal is to have a MinPlatform board which can easily be
used to learn about and experiment with MinPlatform, is that correct?

>  Platform/Qemu/QemuOpenBoardPkg/Library/OpenQemuFwCfgLib/OpenQemuFwCfgLib.inf       |  23 +
>  Platform/Qemu/QemuOpenBoardPkg/Include/Library/OpenQemuFwCfgLib.h                  | 102 +++
>  Platform/Qemu/QemuOpenBoardPkg/Library/OpenQemuFwCfgLib/OpenQemuFwCfgLib.c         | 130 ++++

Why duplicate that lib instead of just using the OvmfPkg version (which
you do elsewhere)?

>  Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Cpu.c                               |  56 ++
>  Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c                            | 244 ++++++++
>  Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pci.c                               |  59 ++
>  Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c                              |  91 +++
>  Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/PlatformInit.c                      |  67 ++

Note that OvmfPkg got a PlatformInitLib recently which you might be able
to use to reduce code duplication (didn't check the code though and
maybe MinPlatform init is different enough that this doesn't help much).

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93092): https://edk2.groups.io/g/devel/message/93092
Mute This Topic: https://groups.io/mt/93282182/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-