[edk2-devel] [PATCH v2 7/8] NetworkPkg/TcpDxe: Fix debug macro arguments

[Maciej Rabeda]

Thanks for the patch, Michael.

Reviewed-by: Maciej Rabeda <maciej.rabeda at linux.intel.com>

On 25 sie 2022 05:48, mikuback at linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki at microsoft.com>
>
> Removes Status argument that is not needed from DEBUG macros.
>
> Cc: Maciej Rabeda <maciej.rabeda at linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu at intel.com>
> Cc: Siyuan Fu <siyuan.fu at intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki at microsoft.com>
> ---
>   NetworkPkg/TcpDxe/SockInterface.c | 12 ++----------
>   1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/NetworkPkg/TcpDxe/SockInterface.c b/NetworkPkg/TcpDxe/SockInterface.c
> index 413d6e1373f3..6e8cbb74a86b 100644
> --- a/NetworkPkg/TcpDxe/SockInterface.c
> +++ b/NetworkPkg/TcpDxe/SockInterface.c
> @@ -661,11 +661,7 @@ SockSend (
>                     );
>   
>       if (NULL == SockToken) {
> -      DEBUG (
> -        (DEBUG_ERROR,
> -         "SockSend: Failed to buffer IO token into socket processing SndToken List\n",
> -         Status)
> -        );
> +      DEBUG ((DEBUG_ERROR, "SockSend: Failed to buffer IO token into socket processing SndToken List\n"));
>   
>         Status = EFI_OUT_OF_RESOURCES;
>         goto Exit;
> @@ -674,11 +670,7 @@ SockSend (
>       Status = SockProcessTcpSndData (Sock, TxData);
>   
>       if (EFI_ERROR (Status)) {
> -      DEBUG (
> -        (DEBUG_ERROR,
> -         "SockSend: Failed to process Snd Data\n",
> -         Status)
> -        );
> +      DEBUG ((DEBUG_ERROR, "SockSend: Failed to process Snd Data\n"));
>   
>         RemoveEntryList (&(SockToken->TokenList));
>         FreePool (SockToken);


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93098): https://edk2.groups.io/g/devel/message/93098
Mute This Topic: https://groups.io/mt/93242253/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-