[edk2-devel] [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang at amd.com>

Hi Ard, please also update Daniel's email address to Daniel Schaefer <git at danielschaefer.me>

Thanks

> -----Original Message-----
> From: Ard Biesheuvel <ardb at kernel.org>
> Sent: Monday, September 5, 2022 9:56 PM
> To: Wenyi Xie <xiewenyi2 at huawei.com>
> Cc: devel at edk2.groups.io; quic_llindhol at quicinc.com;
> ardb+tianocore at kernel.org; Chang, Abner <Abner.Chang at amd.com>;
> daniel.schaefer at hpe.com; songdongkuang at huawei.com
> Subject: Re: [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix
> compile warning
> 
> [CAUTION: External Email]
> 
> On Wed, 3 Aug 2022 at 11:27, Wenyi Xie <xiewenyi2 at huawei.com> wrote:
> >
> > The value of gTimeOut is from PcdGdbMaxPacketRetryCount, and this PCD
> > is UINT32. So change the declaratrion of gTimeOut to UINT32 to fix
> > compile warning.
> >
> > Cc: Leif Lindholm <quic_llindhol at quicinc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> > Cc: Abner Chang <abner.chang at amd.com>
> > Cc: Daniel Schaefer <daniel.schaefer at hpe.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2 at huawei.com>
> > ---
> >  EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2
> > +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > index d53a5fe47f18..d54e1cf7e094 100644
> > ---
> > a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > +++ b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.
> > +++ c
> > @@ -17,7 +17,7 @@
> >  #include <Protocol/DebugPort.h>
> >
> >  EFI_DEBUGPORT_PROTOCOL  *gDebugPort = NULL;
> > -UINTN                   gTimeOut    = 0;
> > +UINT32                  gTimeOut    = 0;
> >
> >  /**
> >    The constructor function initializes the UART.
> > --
> > 2.20.1.windows.1
> >
> 
> Merged as #3287


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93190): https://edk2.groups.io/g/devel/message/93190
Mute This Topic: https://groups.io/mt/92788833/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-