[edk2-devel] [PATCH v2 0/1] AsfFeaturePkg: Add Alert standard format support

CrystalLee [李怡萱] via groups.io CrystalLee=ami.com at groups.io
Mon Sep 5 12:15:16 UTC 2022


Issac,

Thank you for your advice.
I change to edk2-platform repository and create AsfFeaturePkg branch in the forked edk2-platform repository
REF: https://github.com/CrystalLee-77/edk2-platforms/tree/AsfFeaturePkg

Patch V2 change lists:
1. Add the Asf feature in edk2-platforms/Features/Intel/OutOfBandManagement/AsfFeaturePkg
2. Remove AsfAcpitable library. Create PcdControlDataArrays for remote control in Asf Acpi table.
3. Add Readme.md
4. Improve the coding that your provided in the review comments.
   •    Asf.h has a whitespace alignment issue on line 78 -- removed
   •    AsfPei.inf – does it really support EBC?  -- removed EBC support
   •    ## PRODUCES and ## CONSUMES are added in INF
   •    AsfDxe.c – add missing @param in AsfGetBootOption function
     o  Line 331 has a trailing ‘\’ -- removed

Regards,
Crystal

CrystalLee (1):
  Features/Intel/OutOfBandManagement/AsfFeaturePkg: Add initial package

 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfAcpiTable.c          | 234 ++++++++++++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxe.c                | 340 +++++++++++++++++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxeEvent.c           | 319 ++++++++++++++++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfPei/AsfPei.c                | 384 ++++++++++++++++++++
 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc                        |   1 +
 Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc                  |   4 +
 Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc               |   2 +
 Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf                        |   4 +
 Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf                         |   4 +
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxe.h                |  66 ++++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxe.inf              |  51 +++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxe.uni              |  15 +
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxeExtra.uni         |  13 +
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfFeaturePkg.dec              |  47 +++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfFeaturePkg.dsc              |  40 ++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfPei/AsfPei.inf              |  51 +++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfPei/AsfPei.uni              |  15 +
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfPei/AsfPeiExtra.uni         |  13 +
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/AsfFeature.dsc         |  52 +++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/AsfMessages.h          | 104 ++++++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/IndustryStandard/Asf.h | 145 ++++++++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/PostMemory.fdf         |   8 +
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/PreMemory.fdf          |   8 +
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/Protocol/AsfProtocol.h |  57 +++
 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Readme.md                      |  63 ++++
 25 files changed, 2040 insertions(+)
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfAcpiTable.c
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxe.c
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxeEvent.c
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfPei/AsfPei.c
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxe.h
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxe.inf
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxe.uni
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfDxe/AsfDxeExtra.uni
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfFeaturePkg.dec
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfFeaturePkg.dsc
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfPei/AsfPei.inf
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfPei/AsfPei.uni
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/AsfPei/AsfPeiExtra.uni
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/AsfFeature.dsc
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/AsfMessages.h
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/IndustryStandard/Asf.h
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/PostMemory.fdf
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/PreMemory.fdf
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/Protocol/AsfProtocol.h
 create mode 100644 Features/Intel/OutOfBandManagement/AsfFeaturePkg/Readme.md

--
2.36.0.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93222): https://edk2.groups.io/g/devel/message/93222
Mute This Topic: https://groups.io/mt/93500356/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list