[edk2-devel][edk2-platforms][PATCH v1 1/3] MinPlatformPkg, WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: First BoardInitLib

[Nate DeSimone]

It does kind of have a cover letter: https://edk2.groups.io/g/devel/message/93281

But there is no title on the cover letter and the reviewers where not CC'd either. Please remember to do both in the future 😊.

Thanks,
Nate

-----Original Message-----
From: Oram, Isaac W <isaac.w.oram at intel.com> 
Sent: Friday, September 9, 2022 7:38 AM
To: Benjamin Doron <benjamin.doron00 at gmail.com>; devel at edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Sinha, Ankit <ankit.sinha at intel.com>; Chiu, Chasel <chasel.chiu at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Dong, Eric <eric.dong at intel.com>
Subject: RE: [edk2-devel][edk2-platforms][PATCH v1 1/3] MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: First BoardInitLib

Series should have a cover letter.  Please rebase the series and send V2 now that Nate's I2CHdmiDebugSerialPortLib has been merged.

Thanks,
Isaac

-----Original Message-----
From: Benjamin Doron <benjamin.doron00 at gmail.com> 
Sent: Tuesday, September 6, 2022 10:27 AM
To: devel at edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty at intel.com>; Oram, Isaac W <isaac.w.oram at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Sinha, Ankit <ankit.sinha at intel.com>; Chiu, Chasel <chasel.chiu at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Dong, Eric <eric.dong at intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH v1 1/3] MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: First BoardInitLib

SecBoardInitLib is called to enable serial port before SerialPortInitialize and DEBUG().

This is strongly assumed to be necessary for I2cHdmiDebugSerialPortLib in SEC phase, which presently initialises this way.

No testing was performed before, it's assumed too risky unless the GPIO happens to have the desired default. Presently, DEBUG() works in SEC phase.

Cc: Sai Chaganty <rangasai.v.chaganty at intel.com>
Cc: Isaac Oram <isaac.w.oram at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Ankit Sinha <ankit.sinha at intel.com>
Cc: Chasel Chiu <chasel.chiu at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Cc: Eric Dong <eric.dong at intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00 at gmail.com>
---
 .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c    | 8 ++++++--
 .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c    | 8 ++++++--
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
index ef89e3f31018..d74b07bc062b 100644
--- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
+++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlat
+++ formSecLib/PlatformInit.c
@@ -28,6 +28,12 @@ PlatformInit (
   IN VOID                 *EndOfRange   ) {+  //+  // Board/Silicon initialization+  // Prepare controllers before enabling serial port+  //+  BoardAfterTempRamInit ();+   //   // Platform initialization   // Enable Serial port here@@ -41,7 +47,5 @@ PlatformInit (
   DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange));   DEBUG ((DEBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange)); -  BoardAfterTempRamInit ();-   TestPointTempMemoryFunction (StartOfRange, EndOfRange); }diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
index 486c8c72616e..53f95c29bde5 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library
+++ /SecFspWrapperPlatformSecLib/PlatformInit.c
@@ -28,6 +28,12 @@ PlatformInit (
   IN VOID                 *EndOfRange   ) {+  //+  // Board/Silicon initialization+  // Prepare controllers before enabling serial port+  //+  BoardAfterTempRamInit ();+   //   // Platform initialization   // Enable Serial port here@@ -41,7 +47,5 @@ PlatformInit (
   DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange));   DEBUG ((DEBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange)); -  BoardAfterTempRamInit ();-   TestPointTempMemoryFunction (StartOfRange, EndOfRange); }-- 
2.37.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93611): https://edk2.groups.io/g/devel/message/93611
Mute This Topic: https://groups.io/mt/93506700/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-