[edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

Michael D Kinney michael.d.kinney at intel.com
Thu Sep 15 20:51:58 UTC 2022


Ard,

Why would you want to do that?  The whole point of CI is to establish a minimum quality level for all code in the project.

They can be disabled with updates to the YAML file.  Checks can be disabled completely and may of the checks support exception lists.

Mike

> -----Original Message-----
> From: Ard Biesheuvel <ardb at kernel.org>
> Sent: Thursday, September 15, 2022 1:47 PM
> To: Michael Kubacki <mikuback at linux.microsoft.com>
> Cc: devel at edk2.groups.io; Leif Lindholm <quic_llindhol at quicinc.com>; Ard Biesheuvel <ardb+tianocore at kernel.org>; Abner Chang
> <abner.chang at amd.com>; Daniel Schaefer <git at danielschaefer.me>; Kinney, Michael D <michael.d.kinney at intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI
> 
> On Thu, 15 Sept 2022 at 21:46, Michael Kubacki
> <mikuback at linux.microsoft.com> wrote:
> >
> > Hi Ard,
> >
> > I haven't seen any action items for the v1 series.
> >
> > Can you please check the series again and let me know if you have any
> > further concerns?
> >
> 
> The only thing I'd like to know is how I can override the CI and merge
> a PR that was rejected by the checks you are enabling here.
> 
> 
> 
> 
> > On 9/7/2022 11:16 AM, Ard Biesheuvel wrote:
> > > On Wed, 7 Sept 2022 at 17:00, Michael Kubacki
> > > <mikuback at linux.microsoft.com> wrote:
> > >>
> > >> When would you like to have that discussion?
> > >>
> > >> The Tianocore Tool, CI, Codebase meeting is every week. In that meeting
> > >> we've discussed getting all edk2 packages to at least run CI.
> > >>
> > >> https://github.com/tianocore/edk2/discussions/2614
> > >>
> > >> If you prefer to have it here, that's fine as well.
> > >>
> > >
> > > In a nutshell, I am fine with enabling this, as long as I can override
> > > the CI and merge PRs that the CI thinks have issues.
> > >
> > >
> > > 
> > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93870): https://edk2.groups.io/g/devel/message/93870
Mute This Topic: https://groups.io/mt/93517518/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list