[edk2-devel] [PATCH v1 1/1] nasm_ext_dep.yaml: Remove leading zero in patch version

[Michael D Kinney]

Reviewed-by: Michael D Kinney <michael.d.kinney at intel.com>

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Friday, September 16, 2022 1:09 PM
> To: devel at edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Chen, Christine <yuwei.chen at intel.com>; Sean
> Brogan <sean.brogan at microsoft.com>; Kinney, Michael D <michael.d.kinney at intel.com>
> Subject: [edk2-devel] [PATCH v1 1/1] nasm_ext_dep.yaml: Remove leading zero in patch version
> 
> From: Michael Kubacki <michael.kubacki at microsoft.com>
> 
> The patch version is currently: "2.15.05"
> 
> When a formal semantic version validator is run against this version
> it is recognized as being invalid due to the leading zero in the
> patch which is not allowed per the Semantic Versioning Specification:
> 
> https://semver.org/#spec-item-2
> 
> The NuGet Gallery already reports the version without the leading
> zero: https://www.nuget.org/packages/mu_nasm/2.15.5
> 
> This change simply removes the leading zero to prevent code such as
> https://pypi.org/project/semantic-version/ from reporting a version
> error.
> 
> Cc: Bob Feng <bob.c.feng at intel.com>
> Cc: Liming Gao <gaoliming at byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen at intel.com>
> Cc: Sean Brogan <sean.brogan at microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Signed-off-by: Michael Kubacki <mikuback at linux.microsoft.com>
> ---
>  BaseTools/Bin/nasm_ext_dep.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml b/BaseTools/Bin/nasm_ext_dep.yaml
> index 7a56dd2b8bc1..56703d4c18e7 100644
> --- a/BaseTools/Bin/nasm_ext_dep.yaml
> +++ b/BaseTools/Bin/nasm_ext_dep.yaml
> @@ -13,6 +13,6 @@
>    "type": "nuget",
>    "name": "mu_nasm",
>    "source": "https://api.nuget.org/v3/index.json",
> -  "version": "2.15.05",
> +  "version": "2.15.5",
>    "flags": ["set_path", "host_specific"]
>  }
> --
> 2.28.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#93913): https://edk2.groups.io/g/devel/message/93913
> Mute This Topic: https://groups.io/mt/93731048/1643496
> Group Owner: devel+owner at edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney at intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93942): https://edk2.groups.io/g/devel/message/93942
Mute This Topic: https://groups.io/mt/93731048/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-