[edk2-devel] [PATCH v3 0/4] Enable BTI support in memory attributes table

[Marvin Häuser]

> On 4. Apr 2023, at 18:29, Ard Biesheuvel <ardb at kernel.org> wrote:
> On Tue, 4 Apr 2023 at 18:19, Marvin Häuser <mhaeuser at posteo.de> wrote:
>> 
>> FWIW, Reviewed-by: Marvin Häuser <mhaeuser at posteo.de>
>> 
>> An off-topic remark, but I find it ominous that when adding a hack like the DllCharacteristicsEx debug entry, the opportunity is not used to turn it into something that can be expanded in the future without introducing yet another hack like this (I know 31 more Bits look plenty now, but if an address, offset, or size will be needed… ouch).
> 
> It *can* be expanded in the future. The debug directory entry includes
> a size field, and once flags get defined that are not present, they
> just default to unset.

Ugh, I should have known this… sorry for my terrible remark! :)

Though doesn’t that mean the size field should ideally be checked in 3/4 (not regarding the extensibility point, but well-formedness of the data)?

Best regards,
Marvin


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102502): https://edk2.groups.io/g/devel/message/102502
Mute This Topic: https://groups.io/mt/98062730/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-