[edk2-devel] PR fails due to OVMF time out

[Michael D Kinney]

Hi Gerd,

Do you want to submit a new email review/PR with this suggested change?

Thanks,

Mike

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Gerd Hoffmann
> Sent: Monday, April 3, 2023 3:38 AM
> To: devel at edk2.groups.io; ardb at kernel.org
> Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Laszlo Ersek <lersek at redhat.com>; Ni, Ray <ray.ni at intel.com>
> Subject: Re: [edk2-devel] PR fails due to OVMF time out
> 
> On Mon, Apr 03, 2023 at 10:21:27AM +0200, Ard Biesheuvel wrote:
> > On Sun, 2 Apr 2023 at 20:23, Kinney, Michael D
> > <michael.d.kinney at intel.com> wrote:
> > >
> > > Hi Gerd,
> > >
> > > I have investigated this failure with enabling -smp 4.  I think this is an
> > > important feature that should be on by default.
> > >
> >
> > Agreed. And given your investigation below (thanks!), we should be
> > able to revert the revert as long as we add '-accel
> > tcg,thread-single', right?
> 
> That is how I read it, yes.
> 
> > It would be nice if we could also get some coverage for KVM, but for
> > the time being, this seems to be an improvement already (AFAIU, we
> > want -smp 4 primarily for the logic used in the code, while there is
> > very little code that would actually run concurrently, if any)
> 
> Yes, it's to improve MpInit test coverage.  Most code would continue to
> run single-threaded.
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102534): https://edk2.groups.io/g/devel/message/102534
Mute This Topic: https://groups.io/mt/97975047/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3943202/1813853/130120423/xyzzy [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-