[edk2-devel] [PATCH v8 0/9] Adds AmdSmmCpuFeaturesLib and SmmSmramSaveStateLib
Michael D Kinney
michael.d.kinney at intel.com
Tue Apr 11 18:45:29 UTC 2023
For the final version of this patch series, wouldn't only the full implementation commit be required in the git history?
Mike
> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Chang, Abner via groups.io
> Sent: Monday, April 10, 2023 6:08 PM
> To: Kinney, Michael D <michael.d.kinney at intel.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar at amd.com>;
> devel at edk2.groups.io
> Cc: Grimes, Paul <Paul.Grimes at amd.com>; Kirkendall, Garrett <Garrett.Kirkendall at amd.com>; Dong, Eric
> <eric.dong at intel.com>; Ni, Ray <ray.ni at intel.com>; Kumar, Rahul R <rahul.r.kumar at intel.com>; Gerd Hoffmann
> <kraxel at redhat.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>; Ard Biesheuvel
> <ardb+tianocore at kernel.org>; Yao, Jiewen <jiewen.yao at intel.com>; Justen, Jordan L <jordan.l.justen at intel.com>
> Subject: Re: [edk2-devel] [PATCH v8 0/9] Adds AmdSmmCpuFeaturesLib and SmmSmramSaveStateLib
>
> [AMD Official Use Only - General]
>
> Hi Mike,
> I think 5/9 was added for those functions AMD has no implementation as the initial commit, while 6/9 was updated for the
> functions with AMD implementations.
> @Attar, AbdulLateef (Abdul Lateef)can confirm this.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney at intel.com>
> > Sent: Tuesday, April 11, 2023 12:29 AM
> > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar at amd.com>;
> > devel at edk2.groups.io
> > Cc: Grimes, Paul <Paul.Grimes at amd.com>; Kirkendall, Garrett
> > <Garrett.Kirkendall at amd.com>; Chang, Abner <Abner.Chang at amd.com>;
> > Dong, Eric <eric.dong at intel.com>; Ni, Ray <ray.ni at intel.com>; Kumar, Rahul
> > R <rahul.r.kumar at intel.com>; Gerd Hoffmann <kraxel at redhat.com>; Gao,
> > Liming <gaoliming at byosoft.com.cn>; Liu, Zhiguang
> > <zhiguang.liu at intel.com>; Ard Biesheuvel <ardb+tianocore at kernel.org>;
> > Yao, Jiewen <jiewen.yao at intel.com>; Justen, Jordan L
> > <jordan.l.justen at intel.com>; Kinney, Michael D
> > <michael.d.kinney at intel.com>
> > Subject: RE: [PATCH v8 0/9] Adds AmdSmmCpuFeaturesLib and
> > SmmSmramSaveStateLib
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Is there a reason why patches 5 and 6 where not combined?
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: Abdul Lateef Attar <abdattar at amd.com>
> > > Sent: Monday, April 10, 2023 4:10 AM
> > > To: devel at edk2.groups.io
> > > Cc: Abdul Lateef Attar <abdattar at amd.com>; Paul Grimes
> > > <paul.grimes at amd.com>; Garrett Kirkendall
> > > <garrett.kirkendall at amd.com>; Abner Chang <abner.chang at amd.com>;
> > Dong,
> > > Eric <eric.dong at intel.com>; Ni, Ray <ray.ni at intel.com>; Kumar, Rahul R
> > > <rahul.r.kumar at intel.com>; Gerd Hoffmann <kraxel at redhat.com>;
> > Kinney,
> > > Michael D <michael.d.kinney at intel.com>; Gao, Liming
> > > <gaoliming at byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu at intel.com>;
> > > Ard Biesheuvel <ardb+tianocore at kernel.org>; Yao, Jiewen
> > > <jiewen.yao at intel.com>; Justen, Jordan L <jordan.l.justen at intel.com>
> > > Subject: [PATCH v8 0/9] Adds AmdSmmCpuFeaturesLib and
> > > SmmSmramSaveStateLib
> > >
> > > PR: https://github.com/tianocore/edk2/pull/4258
> > >
> > > V8 delta changes:
> > > Addressed review comments from Abner,
> > > Fix the whitespace error.
> > > Seperate the Ovmf changes to another patch
> > > V7 delta changes:
> > > Adds SmmSmramSaveStateLib for Intel processor.
> > > Integrate SmmSmramSaveStateLib library.
> > > V6 delta changes:
> > > Addressed review comments for Ray NI.
> > > removed unnecessary EFIAPI.
> > > V5 delta changes:
> > > rebase to master branch.
> > > updated Reviewed-by
> > > V4 delta changes:
> > > rebase to master branch.
> > > added reviewed-by.
> > > V3 delta changes:
> > > Addressed review comments from Abner chang.
> > > Re-arranged patch order.
> > >
> > > Cc: Paul Grimes <paul.grimes at amd.com>
> > > Cc: Garrett Kirkendall <garrett.kirkendall at amd.com>
> > > Cc: Abner Chang <abner.chang at amd.com>
> > > Cc: Eric Dong <eric.dong at intel.com>
> > > Cc: Ray Ni <ray.ni at intel.com>
> > > Cc: Rahul Kumar <rahul1.kumar at intel.com>
> > > Cc: Gerd Hoffmann <kraxel at redhat.com>
> > > Cc: Michael D Kinney <michael.d.kinney at intel.com>
> > > Cc: Liming Gao <gaoliming at byosoft.com.cn>
> > > Cc: Zhiguang Liu <zhiguang.liu at intel.com>
> > > Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> > > Cc: Jiewen Yao <jiewen.yao at intel.com>
> > > Cc: Jordan Justen <jordan.l.justen at intel.com>
> > > Cc: Abdul Lateef Attar <abdattar at amd.com>
> > >
> > > Abdul Lateef Attar (9):
> > > MdePkg: Adds AMD SMRAM save state map
> > > UefiCpuPkg: Adds SmmSmramSaveStateLib library class
> > > UefiCpuPkg: Implements SmmSmramSaveStateLib library class
> > > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code
> > > UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib
> > > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family
> > > UefiCpuPkg: Implements SmmSmramSaveStateLib for Intel
> > > UefiCpuPkg: Uses SmmSmramSaveStateLib library
> > > OvmfPkg: Uses SmmSmramSaveStateLib library
> > >
> > > UefiCpuPkg/UefiCpuPkg.dec | 4 +
> > > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +
> > > UefiCpuPkg/UefiCpuPkg.dsc | 15 +
> > > .../AmdSmmCpuFeaturesLib.inf | 38 ++
> > > .../AmdSmmSmramSaveStateLib.inf | 28 +
> > > .../IntelSmmSmramSaveStateLib.inf | 28 +
> > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 +
> > > .../Include/Register/Amd/SmramSaveStateMap.h | 194 +++++++
> > > .../Include/Library/SmmSmramSaveStateLib.h | 70 +++
> > > .../SmmSmramSaveStateLib/SmramSaveState.h | 100 ++++
> > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +
> > > .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 445
> > ++++++++++++++++
> > > .../IntelSmmCpuFeaturesLib.c | 128 +++++
> > > .../SmmCpuFeaturesLibCommon.c | 128 -----
> > > .../SmmSmramSaveStateLib/AmdSmramSaveState.c | 286 ++++++++++
> > > .../IntelSmramSaveState.c | 359 +++++++++++++
> > > .../SmramSaveStateCommon.c | 232 ++++++++
> > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 5 +-
> > > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 500 +----------------
> > -
> > > MdePkg/MdePkg.ci.yaml | 4 +-
> > > 20 files changed, 1941 insertions(+), 629 deletions(-) create mode
> > > 100644
> > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf
> > > create mode 100644
> > >
> > UefiCpuPkg/Library/SmmSmramSaveStateLib/AmdSmmSmramSaveStateLib.
> > inf
> > > create mode 100644
> > >
> > UefiCpuPkg/Library/SmmSmramSaveStateLib/IntelSmmSmramSaveStateLib.i
> > nf
> > > create mode 100644
> > MdePkg/Include/Register/Amd/SmramSaveStateMap.h
> > > create mode 100644
> > UefiCpuPkg/Include/Library/SmmSmramSaveStateLib.h
> > > create mode 100644
> > > UefiCpuPkg/Library/SmmSmramSaveStateLib/SmramSaveState.h
> > > create mode 100644
> > > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c
> > > create mode 100644
> > > UefiCpuPkg/Library/SmmSmramSaveStateLib/AmdSmramSaveState.c
> > > create mode 100644
> > > UefiCpuPkg/Library/SmmSmramSaveStateLib/IntelSmramSaveState.c
> > > create mode 100644
> > > UefiCpuPkg/Library/SmmSmramSaveStateLib/SmramSaveStateCommon.c
> > >
> > > --
> > > 2.25.1
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102852): https://edk2.groups.io/g/devel/message/102852
Mute This Topic: https://groups.io/mt/98172946/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3943202/1813853/130120423/xyzzy [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list